Deprecate Cray platform, based on PE modules#43796
Conversation
spackbot-app
bot
added
architecture
core
alalazo
force-pushed
the
deprecation/cray-platform
branch
from
1aac5b0 to
6b453e1
Compare
Thank you for checking @tgamblin. Piz Daint isn't a blocker for you to make this change. Piz Daint will soon be decommissioned very soon, and the software stack provided on the system has been stable for a long time now. So the last release of Spack, or the current head of |
spackbot-app
bot
added
build-environment
build-systems
defaults
intel
python
update-package
labels
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
|
@becker33 can do the honors of merging this ;) |
|
There are still various packages dynamically referring to |
|
Let me check for them. I just checked |
|
Look for |
alalazo
force-pushed
the
deprecation/cray-platform
branch
from
20c2943 to
02bbe3d
Compare
I also added here, protected by: since that seemed the intent? |
alalazo
force-pushed
the
deprecation/cray-platform
branch
from
02bbe3d to
729c0ae
Compare
spackbot-app
bot
added
commands
compilers
documentation
becker33
left a comment
becker33
left a comment
There was a problem hiding this comment.
I think we need to also deprecate the wrappers variant in the cray-mpich package, or otherwise ensure it's always on (maybe make it sticky and a conflict for ~wrappers) since the ~wrappers behavior supports the modules-based system only.
| _xc_craype_dir = "/opt/cray/pe/cdt" | ||
|
|
||
|
|
||
| def slingshot_network(): |
There was a problem hiding this comment.
I'm not quite sure where this should move, but it should move somewhere else. We shouldn't have a platforms/cray module without a Cray platform class in it.
There was a problem hiding this comment.
I kind of agree. I left this here because the function is used in a few packages, so if we move it we might break custom repos. If it's fine to do so, I totally agree we should move it.
Another alternative is to leave a wrapper here with a warning saying the function moved elsewhere.
| # These do not exist on Windows. | ||
| # Enable only for supported target platforms. | ||
|
|
||
| if sys.platform != "win32": | ||
| filter_compiler_wrappers( | ||
| "h5cc", "h5hlcc", "h5fc", "h5hlfc", "h5c++", "h5hlc++", relative_root="bin" | ||
| ) |
There was a problem hiding this comment.
Is this supposed to be part of this PR or separate?
There was a problem hiding this comment.
Part of this PR, it's just that the Cray part went in just before this in #44437
Remove support for `cray` as a separate platform. Any platform previously detected as `cray` is now detected as `linux`. Users who still need platform=cray have to stick to Spack 0.22
Remove support for `cray` as a separate platform. Any platform previously detected as `cray` is now detected as `linux`. Users who still need platform=cray have to stick to Spack 0.22
remove platform=cray (spack#43796) Remove support for `cray` as a separate platform. Any platform previously detected as `cray` is now detected as `linux`. Users who still need platform=cray have to stick to Spack 0.22
5 participants
This PR discontinues support for the Cray platform based on module file inspection.
It also removes any mention of
platform=crayboth in core Spack and in the packages.@becker33