Skip to content

ruamel: pass memo correctly#43745

Merged
haampie merged 2 commits intospack:developfrom
haampie:fix/delete-deepcopy
Apr 19, 2024
Merged

ruamel: pass memo correctly#43745
haampie merged 2 commits intospack:developfrom
haampie:fix/delete-deepcopy

Conversation

@haampie
Copy link
Copy Markdown
Member

@haampie haampie commented Apr 19, 2024 •
edited
Loading

Fix a quadratic complexity bug in ruamel yaml.

To reproduce:

N=256
spack env create -d .
spack -e . add $(spack list | head -n $N)
time spack -e . find

runs in

N before (s) after (s)
256 1.904 1.491
512 3.479 1.627
1024 9.277 2.092
2048 32.003 2.712
4096 126.028 4.135

from 2048 -> 4096 the quadratic bits are dominating ;)

Still awfully slow, though.

@spackbot-app spackbot-app bot added core PR affects Spack core functionality vendored-dependencies labels Apr 19, 2024
alalazo
alalazo reviewed Apr 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@alalazo alalazo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent. Can you add a patch under external/patches and check it applies when you:

$ pip install vendoring
$ vendoring sync

? That would ensure we don't lose this edit when we update dependencies.

@alalazo alalazo self-assigned this Apr 19, 2024
@haampie haampie merged commit 7464098 into spack:develop Apr 19, 2024
@haampie haampie deleted the fix/delete-deepcopy branch April 19, 2024 12:33
tldahlgren pushed a commit to tldahlgren/spack that referenced this pull request Apr 23, 2024
@haampie @tldahlgren
ruamel yaml: fix quadratic complexity bug (spack#43745)
fbf2316
@greenc-FNAL greenc-FNAL mentioned this pull request Apr 24, 2024
Merged
stephenmsachs pushed a commit to stephenmsachs/spack that referenced this pull request Apr 29, 2024
@haampie
ruamel yaml: fix quadratic complexity bug (spack#43745)
fbe3737
teaguesterling pushed a commit to teaguesterling/spack that referenced this pull request Jun 15, 2024
@haampie @teaguesterling
ruamel yaml: fix quadratic complexity bug (spack#43745)
68cc812
@alalazo alalazo mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalazo alalazo alalazo approved these changes

Assignees

@haampie haampie

@alalazo alalazo

Labels

core PR affects Spack core functionality vendored-dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@haampie @alalazo