Add py-tf-keras package, upgrade TFP#43688
Conversation
spackbot-app
bot
added
dependencies
new-package
new-version
python
update-package
labels
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
|
@aweits, I'll gladly add you (or you do it yourself) to the maintainers too, as you're already on TFP etc |
tldahlgren
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@adamjstewart Are you interested in reviewing the new |
|
@aweits Are you okay with being added as a maintainer on the |
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
A lot of this PR looks like it was simply copied from the py-keras package recipe, but I don't think it actually works.
var/spack/repos/builtin/packages/py-tensorflow-probability/package.py
Outdated
Show resolved
Hide resolved
var/spack/repos/builtin/packages/py-tensorflow-probability/package.py
Outdated
Show resolved
Hide resolved
var/spack/repos/builtin/packages/py-tensorflow-probability/package.py
Outdated
Show resolved
Hide resolved
var/spack/repos/builtin/packages/py-tensorflow-probability/package.py
Outdated
Show resolved
Hide resolved
It pretty much was, yes. Is there any reliable way of testing spack packages? I didn't find any image or something, as mentioned, I barely ever succeed, whether in spack envs or outside and whether metal or clean image, it almost always manages to fail at some point |
|
Most Spack packages build for me. Can you try building locally? If you encounter any issue, open an issue and we can get it fixed. |
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
LGTM. Did it build successfully?
|
Still trying to build, I'll ping once it worked out |
|
It fails, as |
|
At least you made it all the way to the final package! |
yes, managed! Seems like past issues have been fixed meanwhile, good to see that! |
This comment was marked as outdated.
This comment was marked as outdated.
|
Is this PR ready to merge now? |
|
@adamjstewart I think this is finally available! It builds, I've strongly simplified the build |
adamjstewart
changed the title
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
I'm trusting you on the py-tf-keras package since it doesn't use a standard way to document its dependencies.
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: import, isort, black, flake8, mypy
==> Modified files
var/spack/repos/builtin/packages/py-tensorflow-probability/package.py
var/spack/repos/builtin/packages/py-tf-keras/package.py
==> Running import checks
import checks were clean
==> Running isort checks
Fixing /tmp/tmpz4n8ccze/spack/var/spack/repos/builtin/packages/py-tf-keras/package.py
isort checks were clean
==> Running black checks
All done! ✨ 🍰 ✨
2 files left unchanged.
black checks were clean
==> Running flake8 checks
var/spack/repos/builtin/packages/py-tf-keras/package.py:5: [F401] 'spack.package.*' imported but unused
flake8 found errors
==> Running mypy checks
Success: no issues found in 632 source files
mypy checks were clean
I've updated the branch with style fixes. |
* enh: add tf-keras package, upgrade TFP * chore: remove legacy deps * chore: fix style * chore: fix style * fix: url * fix: use jax, tensorflow instead of py-jax, py-tensorflow * fix: remove typo * Update var/spack/repos/builtin/packages/py-tensorflow-probability/package.py Co-authored-by: Adam J. Stewart <[email protected]> * fix: typos * fix: swap version * fix: typos * fix: typos * fix: typos * chore: use f strings * enh: move tf-keras to pypi * [@spackbot] updating style on behalf of jonas-eschle * fix: t * enh: add tf-keras package, upgrade TFP * chore: remove legacy deps * chore: fix style * chore: fix style * fix: url * fix: use jax, tensorflow instead of py-jax, py-tensorflow * fix: remove typo * Update var/spack/repos/builtin/packages/py-tensorflow-probability/package.py Co-authored-by: Adam J. Stewart <[email protected]> * fix: typos * fix: swap version * fix: typos * fix: typos * fix: typos * chore: use f strings * enh: move tf-keras to pypi * [@spackbot] updating style on behalf of jonas-eschle * enh: move tf-keras to pypi * enh: move back to releases to make it work, actually * enh: move back to releases to make it work, actually * fix:change back to tar... * Fix concretisation: py-tf-keras only has 2.17, not 2.16, fix checksum * enh: add TFP 0.25 * enh: add tf-keras 2.18 * chore: fix style * fix: remove patch * maybe fix license * Update var/spack/repos/builtin/packages/py-tf-keras/package.py Co-authored-by: Adam J. Stewart <[email protected]> * fix: pipargs global? * Update var/spack/repos/builtin/packages/py-tf-keras/package.py Co-authored-by: Wouter Deconinck <[email protected]> * chore: fix formatting * chore: fix formatting again * fix: pathes in spack * fix: typo * fix: typo * use github package * use pip install * fix typo * fix typo * comment 2.19 out * fix typo * fix typo * fix typo * chore: remove unused patch file * chore: cleanup * chore: add comment about TF version * chore: remove unused Bazel, cleanup imports * [@spackbot] updating style on behalf of jonas-eschle * chore: add star import, degrading readability --------- Co-authored-by: Adam J. Stewart <[email protected]> Co-authored-by: jonas-eschle <[email protected]> Co-authored-by: Bernhard Kaindl <[email protected]> Co-authored-by: Bernhard Kaindl <[email protected]> Co-authored-by: Wouter Deconinck <[email protected]>
5 participants
Upgrade TensorFlow-Probability, which now requires (see release notes) a new package, tf-keras, which is effectively the 2.x version of previous keras.
Added py-tf-keras package