mirror: clean up stage when retrying#43519
Merged
alalazo merged 1 commit intospack:developfrom Oct 23, 2025
Merged
Conversation
Contributor
|
Thanks for doing this. |
alalazo
force-pushed
the
mirror-retry-fix
branch
from
7fdcef8 to
f49e467
Compare
michaelkuhn
force-pushed
the
mirror-retry-fix
branch
from
f49e467 to
284f579
Compare
michaelkuhn
force-pushed
the
mirror-retry-fix
branch
from
284f579 to
9eaeaa9
Compare
michaelkuhn
force-pushed
the
mirror-retry-fix
branch
from
9eaeaa9 to
4d8cc43
Compare
If we do not clean up the stage, retries might use a corrupted stage: 1. Cloning a Git repository succeeds 2. Disk space runs out while copying the repository to the stage 3. Since the stage exists, a retry will simply reuse it without noticing that it is missing files due to the previous error Signed-off-by: Michael Kuhn <[email protected]>
michaelkuhn
force-pushed
the
mirror-retry-fix
branch
from
4d8cc43 to
a0f73e5
Compare
Member
Author
|
@alalazo ping? |
alalazo
approved these changes
Oct 23, 2025
kshea21
pushed a commit
to kshea21/spack
that referenced
this pull request
Nov 4, 2025
If we do not clean up the stage, retries might use a corrupted stage: 1. Cloning a Git repository succeeds 2. Disk space runs out while copying the repository to the stage 3. Since the stage exists, a retry will simply reuse it without noticing that it is missing files due to the previous error Signed-off-by: Michael Kuhn <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we do not clean up the stage, retries might use a corrupted stage: