Don't delete "spack develop" build artifacts after install#43424
Merged
tgamblin merged 9 commits intospack:developfrom Mar 29, 2024
Merged
Don't delete "spack develop" build artifacts after install#43424tgamblin merged 9 commits intospack:developfrom
tgamblin merged 9 commits intospack:developfrom
Conversation
… I had a bug w/ that
spackbot-app
bot
added
commands
core
3 tasks
…essful dev installs leave the stage dirty)
tgamblin
requested changes
Mar 28, 2024
Member
tgamblin
left a comment
tgamblin
left a comment
There was a problem hiding this comment.
I tested this and it looks mostly good. Two requests:
- docstring request below.
- I see a working symlink after I install a package successfully. When I run
spack clean, the stage is removed but the broken symlink remains. Can we remove that on destroy, as well?
| return bool(self.external_path) or bool(self.external_modules) | ||
|
|
||
| @property | ||
| def is_develop(self): |
Member
Author
done
done and test updated |
tgamblin
approved these changes
Mar 29, 2024
G-Ragghianti
pushed a commit
to G-Ragghianti/spack
that referenced
this pull request
Apr 2, 2024
After spack#41373, where we stopped considering the source directory to be the stage for develop builds, we resumed *deleting* the stage even after a successful build. We don't want this for develop builds because developers need to iterate; we should keep the artifacts unless they explicitly run `spack clean`. Now: - [x] Build artifacts for develop packages are not removed after a successful install - [x] They are also not removed before an install starts, i.e. develop packages always reuse prior artifacts, if available. - [x] They can be deleted in any other context, e.g. by running `spack clean --stage`
tldahlgren
pushed a commit
to tldahlgren/spack
that referenced
this pull request
Apr 23, 2024
After spack#41373, where we stopped considering the source directory to be the stage for develop builds, we resumed *deleting* the stage even after a successful build. We don't want this for develop builds because developers need to iterate; we should keep the artifacts unless they explicitly run `spack clean`. Now: - [x] Build artifacts for develop packages are not removed after a successful install - [x] They are also not removed before an install starts, i.e. develop packages always reuse prior artifacts, if available. - [x] They can be deleted in any other context, e.g. by running `spack clean --stage`
teaguesterling
pushed a commit
to teaguesterling/spack
that referenced
this pull request
Jun 15, 2024
After spack#41373, where we stopped considering the source directory to be the stage for develop builds, we resumed *deleting* the stage even after a successful build. We don't want this for develop builds because developers need to iterate; we should keep the artifacts unless they explicitly run `spack clean`. Now: - [x] Build artifacts for develop packages are not removed after a successful install - [x] They are also not removed before an install starts, i.e. develop packages always reuse prior artifacts, if available. - [x] They can be deleted in any other context, e.g. by running `spack clean --stage`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43393.
After #41373, where we stopped considering the source directory to be the stage for develop builds, we resumed deleting the stage even after a successful build.
We don't want this for develop builds because developers need to iterate; we should keep the artifacts unless they explicitly run
spack clean.Now:
spack clean --stage