sgpp: update dependency versions#43178
Merged
alalazo merged 5 commits intospack:developfrom Mar 18, 2024
Merged
Conversation
alalazo
requested changes
Mar 14, 2024
| # TODO Once distutils is removed from SGpp, limit patch to @:3.4.0 | ||
| patch("disable_disutils_deprecation_warning.patch", when="^[email protected]:3.11") | ||
| patch("disable_disutils_deprecation_warning.patch", when="@:3.4.0 ^[email protected]:3.11") | ||
| patch("for_aarch64.patch", when="target=aarch64:") |
Member
There was a problem hiding this comment.
Can you add a brief comment above this patch directive explaining:
- What is the effect of the patch
- Why it is needed
- Where it was taken from
?
Contributor
Author
There was a problem hiding this comment.
I have updated the description of the disable_disutils_deprecation_warning.patch and linked the relevant issue within sgpp.
For the aarch64.patch: This one is only changed by the PR since I moved it up a few lines in the package.py recipe (as I found it odd to not have it together with the other patches within the package). It was added quite a while ago to the spack package in #18968. Of course, I still added a brief description for it.
alalazo
reviewed
Mar 14, 2024
Co-authored-by: Massimiliano Culpo <[email protected]>
leiterrl
approved these changes
Mar 14, 2024
alalazo
reviewed
Mar 18, 2024
alalazo
approved these changes
Mar 18, 2024
mathomp4
pushed a commit
to mathomp4/spack
that referenced
this pull request
Mar 27, 2024
Co-authored-by: Massimiliano Culpo <[email protected]>
teaguesterling
pushed a commit
to teaguesterling/spack
that referenced
this pull request
Jun 15, 2024
Co-authored-by: Massimiliano Culpo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SGpp recently had some changes to make it compatible with Python 3.12. This PR changes its Spack package accordingly (dropping a patch for the master branch and changing/relaxing some version constraints).