octopus: disable gdlib by default#43161
Merged
tldahlgren merged 1 commit intospack:developfrom Mar 13, 2024
Merged
Conversation
tldahlgren
approved these changes
Mar 13, 2024
Contributor
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
LGTM. @RemiLacroix-IDRIS @fangohr ?
tldahlgren
reviewed
Mar 13, 2024
Contributor
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
Technically you are disabling it entirely.
If you want it to be optionally disabled with it disabled by default you'll want to use a variant.
Member
I think that is okay and correct. For the future, Octopus does not need |
fangohr
approved these changes
Mar 13, 2024
iamashwin99
added a commit
to fangohr/octopus-in-spack
that referenced
this pull request
Mar 17, 2024
Includes changes from : - spack/spack#41747 - spack/spack#41003 - spack/spack#41919 - spack/spack#40685 - Add hash for octopus 14 and Update BerkeleyGW dependency version in Octopus package #101 ( done at octopus: Support new version octopus@14 spack/spack#43160) push changes in Disable gdlib #90 (done at octopus: disable gdlib by default spack/spack#43161) - include new maintainer spack/spack#43163
mathomp4
pushed a commit
to mathomp4/spack
that referenced
this pull request
Mar 27, 2024
lang-m
pushed a commit
to mpsd-computational-science/spack
that referenced
this pull request
Apr 8, 2024
teaguesterling
pushed a commit
to teaguesterling/spack
that referenced
this pull request
Jun 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Octopus m4 for gdlib is greedy and picks up gdlib from the system if present.
This causes two kinds of problems:
(see for eg tests/octopus: convert to new stand-alone test process #38010 (comment))
Since gdlib is set to be deprecated by the octopus team (cgal replacing its use case), and it reduces the build issues, we could consider disabling gdlib entirely.