libevent: remove autotools build deps again#42908
Merged
alalazo merged 1 commit intospack:developfrom Feb 29, 2024
Merged
Conversation
The deps were added in spack#40945 to make it work on macOS 11, because the old configure scripts only detect macOS 10. Apparently people the autoreconf script caused issues, later fixed in spack#41057. However, also with that fix, things are incorrect, cause people now report: ``` libtool: You should recreate aclocal.m4 with macros from libtool 2.4.7 libtool: and run autoconf again. ``` I did not check what that error is about exactly, but it looks like Spack's `def autoreconf` step does way less than the `autgen.sh` script provided in the source tarball. HOWEVER, all this is unnecessary, because the underlying issue was already fixed long ago, it's just that it regressed at some point, but it's back in place since spack#41205, therefore, get rid of all this madness.
|
Hi @haampie! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers("haampie")If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame libeventThank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
alalazo
approved these changes
Feb 29, 2024
mathomp4
pushed a commit
to mathomp4/spack
that referenced
this pull request
Mar 27, 2024
The deps were added in spack#40945 to make it work on macOS 11, because the old configure scripts only detect macOS 10. Apparently people reported the autoreconf script caused issues, later fixed in spack#41057. However, also with that fix, things are incorrect, cause people now report: ``` libtool: You should recreate aclocal.m4 with macros from libtool 2.4.7 libtool: and run autoconf again. ``` HOWEVER, all this is unnecessary, because the underlying issue was already fixed long ago, it's just that it regressed at some point, but it's back in place since spack#41205.
teaguesterling
pushed a commit
to teaguesterling/spack
that referenced
this pull request
Jun 15, 2024
The deps were added in spack#40945 to make it work on macOS 11, because the old configure scripts only detect macOS 10. Apparently people reported the autoreconf script caused issues, later fixed in spack#41057. However, also with that fix, things are incorrect, cause people now report: ``` libtool: You should recreate aclocal.m4 with macros from libtool 2.4.7 libtool: and run autoconf again. ``` HOWEVER, all this is unnecessary, because the underlying issue was already fixed long ago, it's just that it regressed at some point, but it's back in place since spack#41205.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deps were added in #40945 to make it work on macOS 11, because the
old configure scripts only detect macOS 10. Apparently the bundled
autogen.sh script caused issues, later fixed in #41057. However, also
with that fix, things are incorrect, cause people now report:
I did not check what that error is about exactly, but it looks like
Spack's
def autoreconfstep does way less than theautogen.shscript provided in the tarball.
HOWEVER, all this is unnecessary, because the underlying issue was
already fixed long ago, it's just that it regressed at some point. With
#41205 it's back in place, and therefore we can get rid of those
redundant build deps.