Skip to content

Add url_for_version function to qt#427

Closed
adamjstewart wants to merge 635 commits intospack:developfrom
adamjstewart:features/qt
Closed

Add url_for_version function to qt#427
adamjstewart wants to merge 635 commits intospack:developfrom
adamjstewart:features/qt

Conversation

@adamjstewart
Copy link
Copy Markdown
Member

If the qt download directory changes one more time...

I added the most recent version, removed a duplicate import, and turned gtkplus into an optional dependency as decided in #166.

version('5.3.2', 'febb001129927a70174467ecb508a682')
version('5.2.1', 'a78408c887c04c34ce615da690e0b4c8')
version('4.8.6', '2edbe4d6c2eff33ef91732602f3518eb')
version('3.3.8b', '9f05b4125cfe477cc52c9742c3c09009')
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, wow. This should probably just be removed…

@adamjstewart
Copy link
Copy Markdown
Member Author

@mathstuf: I would be fine with only keeping versions 5 and above. It would make url_for_version a lot simpler.

Does anyone else have any thoughts on this? How important is being thorough and supporting older versions vs. keeping life simple?

@mathstuf
Copy link
Copy Markdown
Contributor

mathstuf commented Feb 4, 2016

Versions in the 4.8 series and above would be fine. 4 is on its way out, but isn't completely gone yet. Qt3 is pretty much dead at this point. Debian only has Qt3 in oldoldstable, but Qt4 is still around.

@tgamblin
Copy link
Copy Markdown
Member

tgamblin commented Feb 5, 2016

We need to keep 3 for OpenSpeedShop, but I don't see why we need v2.


From: Ben Boeckel
Sent: Thursday, February 04, 2016 1:18:57 PM
To: LLNL/spack
Subject: Re: [spack] Add url_for_version function to qt (#427)

Versions in the 4.8 series and above would be fine. 4 is on its way out, but isn't completely gone yet. Qt3 is pretty much dead at this point. Debian only has Qt3 in oldoldstablehttps://packages.debian.org/search?keywords=libqt3, but Qt4 is still aroundhttps://packages.debian.org/search?keywords=libqt4.


Reply to this email directly or view it on GitHubhttps://github.com//pull/427#issuecomment-180056791.

@adamjstewart
Copy link
Copy Markdown
Member Author

If we're going to keep 5 out of 7 if-statements then we might as well keep all of them just to be thorough.

KineticTheory and others added 23 commits March 21, 2016 16:24
…ying_around

enhancement proposal : customization of module files
- Gave setup_environment and setup_dependent_environment more similar
  signatures. They now allows editing the Spack env and the runtime
  env for *this* package and dependents, respectively.

- modify_module renamed to setup_dependent_python_module for symmetry
  with setup_dependent_environment and to avoid confusion with
  environment modules.

- removed need for patching Package objects at runtime.

- adjust packages to reflect these changes.
+ Installation of subversion may need to be modified to include python and perl
  bindings. I have provided comments to this end, but the code is not active.
…up_dependent_package

- Fixed in package.py
- Fixed wrong prototypes in packages that use it.
- Fixed build_environment to set module variables properly
  - added hacky fix to ensure spec/package consistency in build processes.
  - Need to think about defensive spec copy done by `Repo.get`.  May be
    time to think about an immutable spec implementation.
+ Provide fpic variant for netlib-lapack.
fix mumps: when installed with parmetis has to be linked with metis
dhandeo and others added 14 commits March 31, 2016 10:39
Needed for visit which depends on [email protected]~opengl2
oce: fix bugs related to NULL pointers and compiler optimisation
Fixes install issues on OS/X for Quantum Espresso
+ libdrm depends_on libpciaccess.  Use spack provided libpciaccess.
Allow users to use spack to stage a, potentially complex, package into a
given path.  This is nice for packages with multiple resources that must
be placed, for example LLVM with all sub-projects.
This version actually pulls the path through the package to deliver it
to each stage on creation when passed through the command.  This is
necessary due to the new StageComposite class that makes setting the
path directly on the stage impractical, it also takes the logic out of
package for the most part, which seems like an improvement.
add a path argument to the stage command
@adamjstewart
Copy link
Copy Markdown
Member Author

Someone save me. I have no idea how to use Git...

@tgamblin
Copy link
Copy Markdown
Member

Usually when this happens I just check out develop again and cherry-pick the stuff I want. I can't really see your branches but you may be able to just rebase your PR on your develop branch, which does mostly the same thing.

@tgamblin
Copy link
Copy Markdown
Member

https://xkcd.com/1597/

@adamjstewart
Copy link
Copy Markdown
Member Author

This is so true that I'm not sure if it's sad or funny...

@tgamblin
Copy link
Copy Markdown
Member

git is just homeomorphic endofunctors

@tgamblin
Copy link
Copy Markdown
Member

Seriously, though, I really like git. Learn git!

@adamjstewart
Copy link
Copy Markdown
Member Author

Ugh, fine... Know any good tutorials? I already went through this one: https://www.atlassian.com/git/tutorials/

@tgamblin
Copy link
Copy Markdown
Member

I really liked the book. Reading the whole thing was probably the most helpful thing for me. Or at least chapters 1-5.

@adamjstewart
Copy link
Copy Markdown
Member Author

I'll check it out, thanks!

@adamjstewart adamjstewart deleted the features/qt branch March 31, 2016 19:20
matz-e pushed a commit to matz-e/spack that referenced this pull request Apr 27, 2020
climbfuji added a commit to climbfuji/spack that referenced this pull request May 3, 2024
greenc-FNAL pushed a commit to greenc-FNAL/spack that referenced this pull request Aug 22, 2024
…rootd-mirror

xrootd: add mirror to avoid SSL issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.