Skip to content

openssl : url computation#422

Merged
tgamblin merged 1 commit intospack:developfrom
epfl-scitas:packages/openssl_url
Feb 20, 2016
Merged

openssl : url computation#422
tgamblin merged 1 commit intospack:developfrom
epfl-scitas:packages/openssl_url

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Feb 3, 2016

Modifications :

  • fetching the tarballs of older versions of the library won't break / stop an installation
  • the user will be warned if he tries to install something and has an old version of OpenSSL as a dependency

See #416 and #414 for the related discussion

@alalazo
openssl : added logic to version computation. The package now warns u…
587d356 
…ser if he depends on an old version of the library
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Feb 3, 2016

@mathstuf @adamjstewart @tgamblin @eschnett : could you please have a look and tell me if this is good enough for the time being?

mathstuf
mathstuf reviewed Feb 3, 2016
View reviewed changes
var/spack/repos/builtin/packages/openssl/package.py
Copy link
Copy Markdown
Contributor

@mathstuf mathstuf Feb 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versions which are in the old directory are likely to have known issues. I think the language should be stronger (or we should just ignore the old directory completely.

Copy link
Copy Markdown
Member Author

@alalazo alalazo Feb 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathstuf If you have suggestions they are welcome 😄

Copy link
Copy Markdown
Member Author

@alalazo alalazo Feb 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathstuf Just to make things clear, the warning message will be displayed not only when you deliberately ask spack to install an old version of openssl, but also when you try to build something against the latest version spack knows of (even if it was already installed) and it got outdated.

@adamjstewart
Copy link
Copy Markdown
Member

adamjstewart commented Feb 5, 2016

These changes look fine to me. I tested them and they behave as I expected them to.

tgamblin added a commit that referenced this pull request Feb 20, 2016
@tgamblin
Merge pull request #422 from epfl-scitas/packages/openssl_url
97c3854 
openssl : url computation
@tgamblin tgamblin merged commit 97c3854 into spack:develop Feb 20, 2016
@alalazo alalazo deleted the packages/openssl_url branch February 20, 2016 09:50
@adamjstewart adamjstewart mentioned this pull request Mar 21, 2016
Merged
@alalazo alalazo mentioned this pull request Jul 21, 2016
Closed
climbfuji added a commit to climbfuji/spack that referenced this pull request Apr 18, 2024
@climbfuji
Merge pull request spack#422 from climbfuji/feature/update_jscda_emc_…
1daf6f1 
…spack_stack_from_release_170

Merge release/1.7.0 into jcsda_emc_spack_stack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alalazo @adamjstewart @mathstuf @tgamblin