Skip to content

Spec.format: error on old style format strings#41934

Merged
alalazo merged 1 commit intospack:developfrom
haampie:fix/error-old-style-format-strings
Jan 3, 2024
Merged

Spec.format: error on old style format strings#41934
alalazo merged 1 commit intospack:developfrom
haampie:fix/error-old-style-format-strings

Conversation

@haampie
Copy link
Copy Markdown
Member

@haampie haampie commented Jan 3, 2024 •
edited
Loading

Closes #41786
Closes #37593

Old style format strings ${PACKAGE}-${VERSION}-${HASH} are still causing
issues that are very hard to decipher, and sometimes persist even when updating
projections to something modern, because a wrong prefix was already registered
in the database and gets picked up again:

spack/lib/spack/spack/spec.py

Lines 1822 to 1829 in 375bc6f

def prefix(self):
if not self._concrete:
raise spack.error.SpecError("Spec is not concrete: " + str(self))
if self._prefix is None:
upstream, record = spack.store.STORE.db.query_by_spec_hash(self.dag_hash())
if record and record.path:
self.prefix = record.path

@spackbot-app spackbot-app bot added core PR affects Spack core functionality tests General test capability(ies) labels Jan 3, 2024
@alalazo alalazo merged commit 3e3cd64 into spack:develop Jan 3, 2024
@alalazo alalazo mentioned this pull request Jan 3, 2024
Merged
36 tasks
@haampie haampie deleted the fix/error-old-style-format-strings branch January 3, 2024 16:50
This was linked to issues Jan 4, 2024
compilername.Spec has no attribute compilername #37774
Closed
Add better reporting for the use of old formatting style #39294
Closed
alalazo pushed a commit that referenced this pull request Jan 5, 2024
@haampie @alalazo
Spec.format: error on old style format strings (#41934)
22da52f
alalazo pushed a commit that referenced this pull request Jan 10, 2024
@haampie @alalazo
Spec.format: error on old style format strings (#41934)
58fdefe
haampie added a commit that referenced this pull request Jan 11, 2024
@haampie
Spec.format: error on old style format strings (#41934)
b15f9d0
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 25, 2024
@haampie @RikkiButler20
Spec.format: error on old style format strings (spack#41934)
94ff7c1
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 31, 2024
@haampie @RikkiButler20
Spec.format: error on old style format strings (spack#41934)
ffb7439
greenc-FNAL pushed a commit to FNALssi/spack that referenced this pull request Mar 21, 2024
@haampie @greenc-FNAL
Spec.format: error on old style format strings (spack#41934)
6ece4cb
kwryankrattiger pushed a commit to kwryankrattiger/spack that referenced this pull request Jul 9, 2024
@haampie @kwryankrattiger
Spec.format: error on old style format strings (spack#41934)
c73867e
vjranagit pushed a commit to vjranagit/spack that referenced this pull request Jan 18, 2026
@haampie
Spec.format: error on old style format strings (spack#41934)
55fcffe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalazo alalazo alalazo approved these changes

Assignees

No one assigned

Labels

core PR affects Spack core functionality tests General test capability(ies)

Projects

None yet

Milestone

No milestone

2 participants

@haampie @alalazo