Skip to content

gc tests: replace find() with DB query#41876

Merged
alalazo merged 1 commit intodevelopfrom
fixup-gc-tests
Dec 28, 2023
Merged

gc tests: replace find() with DB query#41876
alalazo merged 1 commit intodevelopfrom
fixup-gc-tests

Conversation

@tgamblin
Copy link
Copy Markdown
Member

@tgamblin tgamblin commented Dec 26, 2023

Per #41731 (comment), This cleans up the tests for spack gc by replacing

assert <string> in find()

with the more precise

assert mutable_database.query_local(<string>)

@tgamblin
gc tests: replace find() with DB query
d9b075f 
Per #41731 (comment), This cleans up
the tests for `spack gc` by replacing

```python
assert <string> in find()
```

with the more precise

```python
assert mutable_database.query_local(<string>)
```
@spackbot-app spackbot-app bot added commands core PR affects Spack core functionality tests General test capability(ies) labels Dec 26, 2023
@tgamblin tgamblin requested a review from haampie December 26, 2023 23:09
@tgamblin tgamblin mentioned this pull request Dec 26, 2023
Merged
4 tasks
@tgamblin tgamblin requested a review from alalazo December 27, 2023 17:18
@alalazo alalazo merged commit 6855512 into develop Dec 28, 2023
@alalazo alalazo deleted the fixup-gc-tests branch December 28, 2023 07:52
@alalazo alalazo self-assigned this Dec 28, 2023
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 25, 2024
@tgamblin @RikkiButler20
gc tests: replace find() with DB query (spack#41876)
52dedd2 
Per spack#41731 (comment), This cleans up
the tests for `spack gc` by replacing

```python
assert <string> in find()
```

with the more precise

```python
assert mutable_database.query_local(<string>)
```
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 31, 2024
@tgamblin @RikkiButler20
gc tests: replace find() with DB query (spack#41876)
3a7aab1 
Per spack#41731 (comment), This cleans up
the tests for `spack gc` by replacing

```python
assert <string> in find()
```

with the more precise

```python
assert mutable_database.query_local(<string>)
```
kwryankrattiger pushed a commit to kwryankrattiger/spack that referenced this pull request Jul 9, 2024
@tgamblin @kwryankrattiger
gc tests: replace find() with DB query (spack#41876)
97ad031 
Per spack#41731 (comment), This cleans up
the tests for `spack gc` by replacing

```python
assert <string> in find()
```

with the more precise

```python
assert mutable_database.query_local(<string>)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalazo alalazo alalazo approved these changes

@haampie haampie Awaiting requested review from haampie

Assignees

@alalazo alalazo

Labels

commands core PR affects Spack core functionality tests General test capability(ies)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tgamblin @alalazo