Paramiko python extensions + his deps and other related extensions by luigi-calori · Pull Request #4158 · spack/spack

luigi-calori · 2017-05-07T11:50:12Z

I need Paramiko and these other extensions. added extension needed in my use case.
unsure is dependency have been specified correctly

adamjstewart · 2017-05-07T13:03:06Z

var/spack/repos/builtin/packages/py-cryptography/package.py

+       and primitives to Python developers"""
+
+    homepage = "https://pypi.python.org/pypi/cryptography"
+    url      = "https://pypi.python.org/packages/ec/5f/d5bc241d06665eed93cd8d3aa7198024ce7833af7a67f6dc92df94e00588/cryptography-1.8.1.tar.gz#md5=9f28a9c141995cd2300d0976b4fac3fb"


Can you change this to:
https://pypi.io/packages/source/c/cryptography/cryptography-1.8.1.tar.gz

adamjstewart · 2017-05-07T13:03:27Z

var/spack/repos/builtin/packages/py-asn1crypto/package.py

+
+    version('0.22.0', '74a8b9402625b38ef19cf3fa69ef8470')
+
+    depends_on('py-setuptools', type=('build', 'link'))


This should probably be build only.

remnant of when using #2548 to build python+tk

adamjstewart · 2017-05-07T13:06:01Z

var/spack/repos/builtin/packages/py-cryptography/package.py

+
+    depends_on('py-setuptools', type=('build', 'link'))
+    depends_on('py-cffi',       type=('build', 'link', 'run'))
+    depends_on('py-asn1crypto', type=('build', 'link', 'run'))


These should be 'build', 'run'. Also, you're missing half a dozen dependencies. Check the setup.py and look at install_requires and setup_requires.

adamjstewart · 2017-05-07T13:06:16Z

var/spack/repos/builtin/packages/py-cryptography/package.py

+
+    version('1.8.1', '9f28a9c141995cd2300d0976b4fac3fb')
+
+    depends_on('py-setuptools', type=('build', 'link'))


Type 'build' only.

adamjstewart · 2017-05-07T13:08:22Z

var/spack/repos/builtin/packages/py-ipaddress/package.py

+
+    version('1.0.18', '310c2dfd64eb6f0df44aa8c59f2334a7')
+
+    # depends_on('py-setuptools', type='build')


You can uncomment this, it uses setuptools if found.

adamjstewart · 2017-05-07T13:09:02Z

var/spack/repos/builtin/packages/py-paramiko/package.py

+class PyParamiko(PythonPackage):
+    """SSH2 protocol library"""
+
+    # FIXME: Add a proper url for your package's homepage here.


Delete this line.

adamjstewart · 2017-05-07T13:09:30Z

var/spack/repos/builtin/packages/py-paramiko/package.py

+
+    version('2.1.2', '41a8ea0e8abb03a6bf59870670d4f46c')
+
+    depends_on('py-setuptools',    type=('build', 'link'))


Type 'build' only.

adamjstewart · 2017-05-07T13:10:59Z

var/spack/repos/builtin/packages/py-paramiko/package.py

+    depends_on('py-cryptography',  type=('build', 'link', 'run'))
+    depends_on('py-enum34',        type=('build', 'link', 'run'))
+    depends_on('py-ipaddress',     type=('build', 'link', 'run'))
+    depends_on('py-idna',          type=('build', 'link', 'run'))


('build', 'run') only.

I see the following requirements:

install_requires=[ 'cryptography>=1.1', 'pyasn1>=0.1.7', ],

Where are the rest coming from? Also, can you be more specific about the versions required?

adamjstewart · 2017-05-07T13:17:13Z

var/spack/repos/builtin/packages/py-pycrypto/package.py

+
+    # depends_on('py-setuptools', type=('build', 'link'))
+    # depends_on('py-setuptools', type='include')
+    # depends_on('gmp')


Yes, it looks like this package requires either gmp or mpir for Crypto.PublicKey._fastmath. You don't have to add the latter, gmp is fine.

adamjstewart · 2017-05-07T13:18:37Z

var/spack/repos/builtin/packages/py-pycrypto/package.py

+    # depends_on('py-setuptools', type=('build', 'link'))
+    # depends_on('py-setuptools', type='include')
+    # depends_on('gmp')
+    # not just build-time, requires pkg_resources


This package doesn't require pkg_resources...

adamjstewart · 2017-05-07T17:11:46Z

var/spack/repos/builtin/packages/py-cryptography/package.py

+    depends_on('[email protected]:',         type=('build', 'run'))
+    depends_on('[email protected]:',          type=('build', 'run'))
+    depends_on('py-enum34',             type=('build', 'run'), when='^python@:3.4')
+    depends_on('py-ipaddress',          type=('build', 'run'), when='^python@:3.3')


Does this actually work? I've had problems with this in the past. See py-flake8 and #2793.

I' ve just built now,
I ' ve tried to follow other packages, some are commented but other are using.
I thought you suggested

If I remember correctly, it depends on whether it needs to be present by default (Python 2.7) or not (Python 3). Basically, if you explicitly specify the version, it will always work. But sometimes, if you don't specify the version and let it choose the latest version of Python 2, it won't work. But if spack spec py-cryptography works, then it works.

I'm checking now but now
spack spec py-ordereddict
seems to pick up [email protected], at least in my case

…pack#4158) * adding paramiko and missing dependencies, setup to work with spack#2548 * adding other deps for paramiko * fix flake8 errors * removed spurious add * address suggestion for proper dependencies * fix cryptography deps * remove FIXME comments and commented depends lines

luigicalori added 4 commits May 6, 2017 02:46

adding paramiko and missing dependencies, setup to work with spack#2548

a654620

adding other deps for paramiko

d9c1415

Merge branch 'develop' of https://github.com/LLNL/spack into pr/paramiko

3302f25

fix flake8 errors

1664b1f

luigi-calori added new-package python labels May 7, 2017

adamjstewart requested changes May 7, 2017

View reviewed changes

luigicalori added 3 commits May 7, 2017 16:38

removed spurious add

871e043

address suggestion for proper dependencies

097b59f

fix cryptography deps

57fb89e

adamjstewart reviewed May 7, 2017

View reviewed changes

remove FIXME comments and commented depends lines

630c4b5

adamjstewart approved these changes May 7, 2017

View reviewed changes

adamjstewart merged commit b65daa9 into spack:develop May 8, 2017

luigi-calori deleted the pr/paramiko branch May 8, 2017 07:19


		version('0.22.0', '74a8b9402625b38ef19cf3fa69ef8470')

		depends_on('py-setuptools', type=('build', 'link'))


		version('1.8.1', '9f28a9c141995cd2300d0976b4fac3fb')

		depends_on('py-setuptools', type=('build', 'link'))


		version('1.0.18', '310c2dfd64eb6f0df44aa8c59f2334a7')

		# depends_on('py-setuptools', type='build')


		version('2.1.2', '41a8ea0e8abb03a6bf59870670d4f46c')

		depends_on('py-setuptools', type=('build', 'link'))

Conversation

luigi-calori commented May 7, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants