Fix typo from https://github.com/spack/spack/pull/35737#41574
Merged
haampie merged 3 commits intospack:developfrom Dec 12, 2023
Conversation
Contributor
Author
|
Fixes build errrors in gitlab-runners pipeline: https://github.com/spack/gitlab-runners/actions/runs/7172771743/job/19530679008#step:7:2521 |
alalazo
previously approved these changes
Dec 12, 2023
Member
|
Also part of #40773 but fine to extract. |
haampie
requested changes
Dec 12, 2023
Comment on lines
+125
to
+128
| for s in self.spec.traverse(deptype=("run", "link"), order="post"): | ||
| python_runtime_env.extend(spack.user_environment.environment_modifications_for_spec(s)) | ||
| python_runtime_env.extend( | ||
| spack.user_environment.environment_modifications_for_specs(s) | ||
| ) |
Member
There was a problem hiding this comment.
Can you take the changes from https://github.com/spack/spack/blob/4e2e043237c30b76d034bccefadbff494ae24b59/var/spack/repos/builtin/packages/clingo-bootstrap/package.py?
The loop causes quadratic complexity for a linear operation.
alalazo
approved these changes
Dec 12, 2023
alalazo
pushed a commit
that referenced
this pull request
Jan 2, 2024
alalazo
pushed a commit
that referenced
this pull request
Jan 10, 2024
haampie
pushed a commit
that referenced
this pull request
Jan 11, 2024
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
greenc-FNAL
pushed a commit
to FNALssi/spack
that referenced
this pull request
Mar 21, 2024
kwryankrattiger
pushed a commit
to kwryankrattiger/spack
that referenced
this pull request
Jul 9, 2024
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
fwerner
pushed a commit
to fwerner/spack
that referenced
this pull request
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.