LibraryList and HeaderList not ordered properly#4156
Merged
tgamblin merged 1 commit intospack:developfrom May 11, 2017
Merged
Conversation
davydden
approved these changes
May 7, 2017
Member
Author
|
Forgot to mention: this is a real issue when building, for instance, any Makefile based package against Intel MPI or MKL as you'll get the library order scrambled. |
adamjstewart
reviewed
May 7, 2017
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
I guess I'm not sure of the performance impact of poking the filesystem. Is the more complicated code worth the time savings?
lib/spack/llnl/util/filesystem.py
Outdated
| found_files = [] | ||
|
|
||
| # The variable here is **on purpose** a defaultdict. The idea is that | ||
| # we want to poke the filesystem as least as possible, but still maintain |
Member
Author
There was a problem hiding this comment.
Fix incoming, pretend I never did this.
Member
Author
So, two things:
|
… output) PR spack#3367 inadvertently changed the semantics of _find_recursive and _find_non_recursive so that the returned list are not ordered as the input search list. This commit restores the original semantic, and adds tests to verify it.
alalazo
force-pushed
the
fixes/order_of_files_may_be_incorrect
branch
from
6fa116c to
6fae442
Compare
adamjstewart
approved these changes
May 7, 2017
Member
Author
|
@tgamblin ping |
tgamblin
approved these changes
May 11, 2017
diaena
pushed a commit
to diaena/spack
that referenced
this pull request
May 26, 2017
… output) (spack#4156) PR spack#3367 inadvertently changed the semantics of _find_recursive and _find_non_recursive so that the returned list are not ordered as the input search list. This commit restores the original semantic, and adds tests to verify it.
xavierandrade
pushed a commit
to xavierandrade/spack
that referenced
this pull request
Jun 16, 2017
… output) (spack#4156) PR spack#3367 inadvertently changed the semantics of _find_recursive and _find_non_recursive so that the returned list are not ordered as the input search list. This commit restores the original semantic, and adds tests to verify it.
EmreAtes
pushed a commit
to EmreAtes/spack
that referenced
this pull request
Jul 10, 2017
… output) (spack#4156) PR spack#3367 inadvertently changed the semantics of _find_recursive and _find_non_recursive so that the returned list are not ordered as the input search list. This commit restores the original semantic, and adds tests to verify it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3367 inadvertently changed the semantics of
_find_recursiveand_find_non_recursiveso that the returned list are not ordered as the input search list. This commit restores the original semantic, and adds tests to verify it.