Skip to content

argparse: make scope choices lazy s.t. validation in tests works#41344

Merged
haampie merged 2 commits intospack:developfrom
haampie:fix/config-scope-argparse-issue
Nov 30, 2023
Merged

argparse: make scope choices lazy s.t. validation in tests works#41344
haampie merged 2 commits intospack:developfrom
haampie:fix/config-scope-argparse-issue

Conversation

@haampie
Copy link
Copy Markdown
Member

@haampie haampie commented Nov 29, 2023

Closes #41306

Previously spack unit-test lib/spack/spack/test/cmd/config.py failed because
argparse initialized choices with a non-standard set of scopes once and for
all.

@spackbot-app spackbot-app bot added commands core PR affects Spack core functionality labels Nov 29, 2023
@alalazo
Copy link
Copy Markdown
Member

alalazo commented Nov 30, 2023

@spackbot run pipeline

@alalazo alalazo self-assigned this Nov 30, 2023
@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Nov 30, 2023

I've started that pipeline for you!

@haampie haampie merged commit 4b93c57 into spack:develop Nov 30, 2023
@haampie haampie deleted the fix/config-scope-argparse-issue branch November 30, 2023 07:37
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commands core PR affects Spack core functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spurious test errors

2 participants