tests: fix issue with os.environ binding#41342
Merged
alalazo merged 1 commit intospack:developfrom Nov 30, 2023
Merged
Conversation
spackbot-app
bot
added
core
Member
Author
|
lmao, this one fails due to the issue resolved in #41344 |
alalazo
approved these changes
Nov 30, 2023
alalazo
pushed a commit
that referenced
this pull request
Jan 2, 2024
alalazo
pushed a commit
that referenced
this pull request
Jan 10, 2024
haampie
added a commit
that referenced
this pull request
Jan 11, 2024
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this
spack unit-test lib/spack/spack/test/util/environment.py lib/spack/spack/test/module_parsing.pyfailed.I don't wanna figure out what's wrong with rebinding
os.environto something else, but mutating the instance is more sensible to me anyways; maybe in the fixtureos.environafter yielding still refers to the original instance, somehow?