Refactor a test to not use the "working_env" fixture#41308
Merged
haampie merged 2 commits intospack:developfrom Nov 29, 2023
Merged
Refactor a test to not use the "working_env" fixture#41308haampie merged 2 commits intospack:developfrom
haampie merged 2 commits intospack:developfrom
Conversation
spackbot-app
bot
added
core
Member
|
I reverted a change to this test in my PR. Can you make it such that That way you can unit test it without side effects |
Member
Author
|
Nice, this fails on #41306 🥲 |
This test is flakey, and fails spuriously in CI since a few days. See for instance: https://github.com/spack/spack/actions/runs/7019642159/job/19097775656
haampie
force-pushed
the
ci/refactor-a-flakey-test
branch
from
762822e to
8e93e81
Compare
haampie
reviewed
Nov 29, 2023
| t.write(content) | ||
| yield tmpdir | ||
|
|
||
| # Once done, cleanup the directory |
Member
There was a problem hiding this comment.
not directly related but well...
Member
|
This PR is still fine, but #41342 fixes the underlying issue instead of working around it. |
haampie
approved these changes
Nov 29, 2023
alalazo
added a commit
that referenced
this pull request
Jan 2, 2024
Co-authored-by: Harmen Stoppels <[email protected]>
alalazo
added a commit
that referenced
this pull request
Jan 10, 2024
Co-authored-by: Harmen Stoppels <[email protected]>
haampie
added a commit
that referenced
this pull request
Jan 11, 2024
Co-authored-by: Harmen Stoppels <[email protected]>
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
Co-authored-by: Harmen Stoppels <[email protected]>
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
Co-authored-by: Harmen Stoppels <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is flakey, and fails spuriously in CI since a few days. See for instance:
https://github.com/spack/spack/actions/runs/7019642159/job/19097775656
Given the comment in the "working_env" fixture:
spack/lib/spack/spack/test/conftest.py
Lines 420 to 428 in 4b41b11
it has been refactored to use
monkeypatch. 🤞 we won't see spurious failure afterwards.