Merged
Conversation
spackbot-app
bot
requested review from
HadrienG2,
drbenmorgan,
gartung,
greenc-FNAL,
marcmengel,
vitodb and
vvolkl
jmcarcell
force-pushed
the
root-patch
branch
2 times, most recently
from
807229c to
e39dc74
Compare
jmcarcell
force-pushed
the
root-patch
branch
from
e39dc74 to
9d77f1b
Compare
alalazo
reviewed
Nov 28, 2023
Co-authored-by: Massimiliano Culpo <[email protected]>
alalazo
previously approved these changes
Nov 28, 2023
greenc-FNAL
approved these changes
Nov 28, 2023
Member
|
@jmcarcell Many thanks for this! |
This was referenced Nov 29, 2023
This was referenced Dec 3, 2023
wdconinc
pushed a commit
to eic/spack
that referenced
this pull request
Jan 7, 2024
* root: add a webgui patch * Update var/spack/repos/builtin/packages/root/package.py Co-authored-by: Massimiliano Culpo <[email protected]> * Add also the versions that don't need the webgui patch * Fix hash --------- Co-authored-by: jmcarcell <[email protected]> Co-authored-by: Massimiliano Culpo <[email protected]>
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
* root: add a webgui patch * Update var/spack/repos/builtin/packages/root/package.py Co-authored-by: Massimiliano Culpo <[email protected]> * Add also the versions that don't need the webgui patch * Fix hash --------- Co-authored-by: jmcarcell <[email protected]> Co-authored-by: Massimiliano Culpo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch tested on 6.26.00, 6.28.00 and 6.30.00 @greenc-FNAL is aware
Edit: I have also added the first versions that don't need this patch