spack graph: fix coloring with environments#41240
Merged
haampie merged 1 commit intospack:developfrom Nov 24, 2023
Merged
Conversation
If we use all specs, we won't color correctly build-only dependencies
haampie
approved these changes
Nov 24, 2023
haampie
pushed a commit
that referenced
this pull request
Nov 24, 2023
If we use all specs, we won't color correctly build-only dependencies
This was referenced Nov 29, 2023
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Dec 14, 2023
If we use all specs, we won't color correctly build-only dependencies
alalazo
added a commit
that referenced
this pull request
Jan 10, 2024
If we use all specs, we won't color correctly build-only dependencies
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
If we use all specs, we won't color correctly build-only dependencies
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
If we use all specs, we won't color correctly build-only dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we use
env.all_specs(), we won't color correctly build-only dependencies (since we'll graph all nodes explicitly). With this fix they are displayed with a different color.For instance, in the following graph:
The pure build dependencies (in red) are colored blue.