setup_platform_environment before package env mods#41205
Merged
haampie merged 2 commits intospack:developfrom Nov 22, 2023
Merged
setup_platform_environment before package env mods#41205haampie merged 2 commits intospack:developfrom
haampie merged 2 commits intospack:developfrom
Conversation
This restores the order from before where `AutotoolsPackage` would override the env variable set in `setup_platform_environment`.
This was referenced Nov 21, 2023
Closed
tgymnich
approved these changes
Nov 22, 2023
Member
tgymnich
left a comment
There was a problem hiding this comment.
This seems to fix the issue for me.
sethrj
previously approved these changes
Nov 22, 2023
Contributor
sethrj
left a comment
There was a problem hiding this comment.
Could be improved by a comment describing why (and that!) the order matters
Member
Author
|
I noticed that the original order was:
I don't think that makes much sense given that It may matter for cray, but I think it's unlikely, cause compiler modules and external package modules are loaded after these 3 steps anyways, so What a mess! |
sethrj
approved these changes
Nov 22, 2023
4 tasks
climbfuji
pushed a commit
to AlexanderRichert-NOAA/spack
that referenced
this pull request
Nov 22, 2023
This roughly restores the order of operation from Spack 0.20, where where `AutotoolsPackage.setup_build_environment` would override the env variable set in `setup_platform_environment` on macOS.
3 tasks
haampie
added a commit
that referenced
this pull request
Nov 23, 2023
This roughly restores the order of operation from Spack 0.20, where where `AutotoolsPackage.setup_build_environment` would override the env variable set in `setup_platform_environment` on macOS.
gabrielctn
pushed a commit
to gabrielctn/spack
that referenced
this pull request
Nov 24, 2023
This roughly restores the order of operation from Spack 0.20, where where `AutotoolsPackage.setup_build_environment` would override the env variable set in `setup_platform_environment` on macOS.
This was referenced Nov 29, 2023
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Dec 14, 2023
This roughly restores the order of operation from Spack 0.20, where where `AutotoolsPackage.setup_build_environment` would override the env variable set in `setup_platform_environment` on macOS.
alalazo
pushed a commit
that referenced
this pull request
Jan 10, 2024
This roughly restores the order of operation from Spack 0.20, where where `AutotoolsPackage.setup_build_environment` would override the env variable set in `setup_platform_environment` on macOS.
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
This roughly restores the order of operation from Spack 0.20, where where `AutotoolsPackage.setup_build_environment` would override the env variable set in `setup_platform_environment` on macOS.
haampie
added a commit
to haampie/spack
that referenced
this pull request
Feb 28, 2024
The deps were added in spack#40945 to make it work on macOS 11, because the old configure scripts only detect macOS 10. Apparently people the autoreconf script caused issues, later fixed in spack#41057. However, also with that fix, things are incorrect, cause people now report: ``` libtool: You should recreate aclocal.m4 with macros from libtool 2.4.7 libtool: and run autoconf again. ``` I did not check what that error is about exactly, but it looks like Spack's `def autoreconf` step does way less than the `autgen.sh` script provided in the source tarball. HOWEVER, all this is unnecessary, because the underlying issue was already fixed long ago, it's just that it regressed at some point, but it's back in place since spack#41205, therefore, get rid of all this madness.
alalazo
pushed a commit
that referenced
this pull request
Feb 29, 2024
The deps were added in #40945 to make it work on macOS 11, because the old configure scripts only detect macOS 10. Apparently people reported the autoreconf script caused issues, later fixed in #41057. However, also with that fix, things are incorrect, cause people now report: ``` libtool: You should recreate aclocal.m4 with macros from libtool 2.4.7 libtool: and run autoconf again. ``` HOWEVER, all this is unnecessary, because the underlying issue was already fixed long ago, it's just that it regressed at some point, but it's back in place since #41205.
mathomp4
pushed a commit
to mathomp4/spack
that referenced
this pull request
Mar 27, 2024
The deps were added in spack#40945 to make it work on macOS 11, because the old configure scripts only detect macOS 10. Apparently people reported the autoreconf script caused issues, later fixed in spack#41057. However, also with that fix, things are incorrect, cause people now report: ``` libtool: You should recreate aclocal.m4 with macros from libtool 2.4.7 libtool: and run autoconf again. ``` HOWEVER, all this is unnecessary, because the underlying issue was already fixed long ago, it's just that it regressed at some point, but it's back in place since spack#41205.
teaguesterling
pushed a commit
to teaguesterling/spack
that referenced
this pull request
Jun 15, 2024
The deps were added in spack#40945 to make it work on macOS 11, because the old configure scripts only detect macOS 10. Apparently people reported the autoreconf script caused issues, later fixed in spack#41057. However, also with that fix, things are incorrect, cause people now report: ``` libtool: You should recreate aclocal.m4 with macros from libtool 2.4.7 libtool: and run autoconf again. ``` HOWEVER, all this is unnecessary, because the underlying issue was already fixed long ago, it's just that it regressed at some point, but it's back in place since spack#41205.
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
This roughly restores the order of operation from Spack 0.20, where where `AutotoolsPackage.setup_build_environment` would override the env variable set in `setup_platform_environment` on macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the order from before where
AutotoolsPackagewouldoverride the env variable set in
setup_platform_environment.