MSVC preview version breaks clingo build#41185
Merged
alalazo merged 2 commits intospack:developfrom Nov 20, 2023
Merged
Conversation
Prevent preview versions from being used for bootstrapping clingo until patch is ready
Contributor
Author
|
@alalazo This should resolve the bootstrapping issue, 19.38 is the MSC_VER that adds the breaking change to the standard library, so we just bootstrap with 19.37 now. Edit: clingo patch coming soon, just don't want to hold any other PRs up on this. |
haampie
reviewed
Nov 20, 2023
Use correct version constraints Co-authored-by: Harmen Stoppels <[email protected]>
alalazo
approved these changes
Nov 20, 2023
Member
|
Thanks! |
haampie
added a commit
that referenced
this pull request
Nov 23, 2023
Co-authored-by: Harmen Stoppels <[email protected]>
gabrielctn
pushed a commit
to gabrielctn/spack
that referenced
this pull request
Nov 24, 2023
Co-authored-by: Harmen Stoppels <[email protected]>
This was referenced Nov 29, 2023
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Dec 14, 2023
Co-authored-by: Harmen Stoppels <[email protected]>
alalazo
pushed a commit
that referenced
this pull request
Jan 10, 2024
Co-authored-by: Harmen Stoppels <[email protected]>
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
Co-authored-by: Harmen Stoppels <[email protected]>
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
Co-authored-by: Harmen Stoppels <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent preview versions from being used for bootstrapping clingo until patch is ready