spack style: fix isort on sl:7#41133
Conversation
fixes spack#41096 Bump the minimum version required for isort. This should fix an issue reported on Scientific Linux 7, and due to: PyCQA/isort#1363
spackbot-app
bot
added
core
| def isort_root_spec() -> str: | ||
| """Return the root spec used to bootstrap isort""" | ||
| return _root_spec("py-isort@4.3.5:") | ||
| return _root_spec("py-isort@5") |
There was a problem hiding this comment.
| return _root_spec("py-isort@5") | |
| return _root_spec("py-isort@5:") |
There was a problem hiding this comment.
This is minor, but I would still keep this. isort might have breaking changes on major versions, which is what was happening here. Also, we are not capping at the library level, but at the spack style dependency level.
There was a problem hiding this comment.
Up to you. I'm just afraid we'll forget to bump this to 5:6 once 6 is released. We'll eventually end up in the situation where someone is forced to use an old version of Spack (which only supports 5) but needs a newer isort for some reason due to a change in how isort works.
alalazo
force-pushed
the
bugfix/spack-style-fix-isort
branch
from
3539830 to
8332c9c
Compare
alalazo
force-pushed
the
bugfix/spack-style-fix-isort
branch
from
8332c9c to
b862c70
Compare
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
This is now technically correct
| depends_on("[email protected]:3", when="@5.10") | ||
| depends_on("[email protected]:3", when="@5.9") |
There was a problem hiding this comment.
Could be combined like they used to be.
|
@alalazo why is this marked 0.21.1? It's modifying packages. |
|
It solves an issue with bootstrapping but I'm fine if we don't want the bugfix in the point release. |
Bump the minimum version required for isort. This should fix an issue reported on Scientific Linux 7, and due to: PyCQA/isort#1363
Bump the minimum version required for isort. This should fix an issue reported on Scientific Linux 7, and due to: PyCQA/isort#1363
Bump the minimum version required for isort. This should fix an issue reported on Scientific Linux 7, and due to: PyCQA/isort#1363
4 participants
fixes #41096
Bump the minimum version required for isort. This should fix an issue reported on Scientific Linux 7, and due to:
PyCQA/isort#1363