Skip to content

Add audit check to spot when= arguments using wrong named specs#41107

Merged
haampie merged 2 commits intospack:developfrom
alalazo:bugfix/error-messages-lbann
Nov 16, 2023
Merged

Add audit check to spot when= arguments using wrong named specs#41107
haampie merged 2 commits intospack:developfrom
alalazo:bugfix/error-messages-lbann

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Nov 16, 2023

fixes #41059

Modifications:

  • Adds a new audit
  • Fixes issues in packages reported by the audit

@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Nov 16, 2023

In the case reported in the issue the audit shows:
Screenshot from 2023-11-16 11-41-07

@alalazo alalazo mentioned this pull request Nov 16, 2023
36 tasks
Copy link
Copy Markdown
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we caught these!

@haampie haampie merged commit 1e1cb68 into spack:develop Nov 16, 2023
@alalazo alalazo deleted the bugfix/error-messages-lbann branch November 16, 2023 13:26
alalazo added a commit that referenced this pull request Nov 17, 2023
…1107)

* Add audit check to spot when= arguments using named specs

* Fix package issues caught by the new audit
gabrielctn pushed a commit to gabrielctn/spack that referenced this pull request Nov 24, 2023
…ack#41107)

* Add audit check to spot when= arguments using named specs

* Fix package issues caught by the new audit
mtaillefumier pushed a commit to mtaillefumier/spack that referenced this pull request Dec 14, 2023
…ack#41107)

* Add audit check to spot when= arguments using named specs

* Fix package issues caught by the new audit
alalazo added a commit that referenced this pull request Jan 10, 2024
…1107)

* Add audit check to spot when= arguments using named specs

* Fix package issues caught by the new audit
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 31, 2024
…ack#41107)

* Add audit check to spot when= arguments using named specs

* Fix package issues caught by the new audit
vjranagit pushed a commit to vjranagit/spack that referenced this pull request Jan 18, 2026
…ack#41107)

* Add audit check to spot when= arguments using named specs

* Fix package issues caught by the new audit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unclear error message for a typo in a depends_on directive

4 participants