Improve the error message for deprecated preferences#41075
Merged
alalazo merged 3 commits intospack:developfrom Nov 16, 2023
Merged
Improve the error message for deprecated preferences#41075alalazo merged 3 commits intospack:developfrom
alalazo merged 3 commits intospack:developfrom
Conversation
Member
|
Maybe it should say that these type of preferences do not affect concretization because they are always overridden by other criteria. Otherwise it seems that spack 0.22.dev actively ignores them and is actually breaking behavior |
marcmengel
approved these changes
Nov 15, 2023
Contributor
marcmengel
left a comment
marcmengel
left a comment
There was a problem hiding this comment.
It's a definite improvement. I'll take it.
(I still think line/file info on the warning would be a Good Thing, but that is probably buried in the yaml parser somewhere... )
tldahlgren
reviewed
Nov 16, 2023
Contributor
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
Just a nit and question.
The audit shows also the files:lines where the error occurs. Also, address review comments.
alalazo
force-pushed
the
errors/improve-message-preferences
branch
from
edf65b9 to
9ce350e
Compare
Co-authored-by: Tamara Dahlgren <[email protected]>
Member
Author
|
@marcmengel I pushed an improvement. This is what the audit shows on the config you gave me yesterday: |
alalazo
added a commit
that referenced
this pull request
Nov 17, 2023
Improves the warning for deprecated preferences, and adds a configuration audit to get files:lines details of the issues. Co-authored-by: Tamara Dahlgren <[email protected]>
gabrielctn
pushed a commit
to gabrielctn/spack
that referenced
this pull request
Nov 24, 2023
Improves the warning for deprecated preferences, and adds a configuration audit to get files:lines details of the issues. Co-authored-by: Tamara Dahlgren <[email protected]>
This was referenced Nov 29, 2023
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Dec 14, 2023
Improves the warning for deprecated preferences, and adds a configuration audit to get files:lines details of the issues. Co-authored-by: Tamara Dahlgren <[email protected]>
alalazo
added a commit
that referenced
this pull request
Jan 10, 2024
Improves the warning for deprecated preferences, and adds a configuration audit to get files:lines details of the issues. Co-authored-by: Tamara Dahlgren <[email protected]>
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
Improves the warning for deprecated preferences, and adds a configuration audit to get files:lines details of the issues. Co-authored-by: Tamara Dahlgren <[email protected]>
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
Improves the warning for deprecated preferences, and adds a configuration audit to get files:lines details of the issues. Co-authored-by: Tamara Dahlgren <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the warning for deprecated preferences, and adds a configuration audit to get files:lines details of the issues. The result is the following:
The audit is to avoid more complex analysis every time the config file is loaded.