Skip to content

docs: document how spack picks a version / variant#41070

Merged
haampie merged 8 commits intospack:developfrom
haampie:docs/note-about-understanding-concretizer-output
Nov 20, 2023
Merged

docs: document how spack picks a version / variant#41070
haampie merged 8 commits intospack:developfrom
haampie:docs/note-about-understanding-concretizer-output

Conversation

@haampie
Copy link
Copy Markdown
Member

@haampie haampie commented Nov 14, 2023

Add some docs for common questions around concretization

@spackbot-app spackbot-app bot added core PR affects Spack core functionality documentation Improvements or additions to documentation labels Nov 14, 2023
@haampie haampie changed the title docs: document "how spack picks a version / variant" docs: document how spack picks a version / variant Nov 14, 2023
@haampie haampie force-pushed the docs/note-about-understanding-concretizer-output branch from e365a37 to 0215466 Compare November 14, 2023 20:22
@haampie haampie requested a review from tldahlgren November 14, 2023 20:51
Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial comments on the introduction.

tldahlgren
tldahlgren previously approved these changes Nov 15, 2023
Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a minor suggestion about highlighting your last "paragraph".

I'm also wondering if it's worth also referencing this FAQ question in the configuration section?

@haampie haampie force-pushed the docs/note-about-understanding-concretizer-output branch from 16efee4 to 4ff46a3 Compare November 15, 2023 18:22
@haampie haampie requested a review from tldahlgren November 15, 2023 20:01
@haampie haampie added this to the v0.21.1 milestone Nov 15, 2023
Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This keeps getting better. Love the addition of seealso!

Just a minor concern about the potential confusion for a newbie regarding reuse options.

.. code-block:: yaml

concretizer:
reuse: dependencies / true / false
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be confusing for new people. Perhaps explain the values the options can take and provide only one in the example?

@haampie
Copy link
Copy Markdown
Member Author

haampie commented Nov 16, 2023

https://spack--41070.org.readthedocs.build/en/41070/frequently_asked_questions.html I think it's good to go

Will add this to the backports so it appears a bit earlier in a tagged release.

@haampie haampie merged commit 55d2ee9 into spack:develop Nov 20, 2023
@haampie haampie deleted the docs/note-about-understanding-concretizer-output branch November 20, 2023 08:00
@haampie haampie mentioned this pull request Nov 20, 2023
36 tasks
gabrielctn pushed a commit to gabrielctn/spack that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core PR affects Spack core functionality documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants