Skip to content

Backports v0.21.1#41063

Merged
alalazo merged 35 commits intoreleases/v0.21from
backports/v0.21.1
Jan 10, 2024
Merged

Backports v0.21.1#41063
alalazo merged 35 commits intoreleases/v0.21from
backports/v0.21.1

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Nov 14, 2023

@spackbot-app spackbot-app bot added the core PR affects Spack core functionality label Nov 14, 2023
@alalazo alalazo added this to the v0.21.1 milestone Nov 14, 2023
@spackbot-app spackbot-app bot added the documentation Improvements or additions to documentation label Nov 15, 2023
@michaelkuhn
Copy link
Copy Markdown
Member

It would be nice if we could also backport #41126 since the aliases example in the release notes is currently broken.

alalazo and others added 2 commits November 17, 2023 13:42
…1107)

* Add audit check to spot when= arguments using named specs

* Fix package issues caught by the new audit
Improves the warning for deprecated preferences, and adds a configuration
audit to get files:lines details of the issues.

Co-authored-by: Tamara Dahlgren <[email protected]>
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Nov 17, 2023

@michaelkuhn Feel free to add to the list above!

haampie and others added 4 commits November 20, 2023 15:39
When improving the error message, we started #showing in the
answer set a lot more symbols - but we forgot to suppress the
debug messages warning about UNKNOWN SYMBOLs
This roughly restores the order of operation from Spack 0.20,
where where `AutotoolsPackage.setup_build_environment` would
override the env variable set in `setup_platform_environment` on
macOS.
@spackbot-app spackbot-app bot added build-environment tests General test capability(ies) labels Nov 23, 2023
johnwparent and others added 4 commits November 23, 2023 08:37
If we use all specs, we won't color correctly build-only dependencies
PR #40929 reverted the argument parsing to make `spack --verbose
install` work again. It looks like `--verbose` is the only instance
where this kind of argument inheritance is used since all other commands
override arguments with the same name instead. For instance, `spack
--bootstrap clean` does not invoke `spack clean --bootstrap`.

Therefore, fix multi-line aliases again by parsing the resolved
arguments and instead explicitly pass down `args.verbose` to commands.
@wdconinc
Copy link
Copy Markdown
Contributor

wdconinc commented Dec 5, 2023

Thoughts on backporting #41404 from people here? What's the past record of backporting security issues in packages? Does that rise to the level of concern that we want it backported? If no concern here, I'll add it to the list and merge that PR.

@becker33
Copy link
Copy Markdown
Member

becker33 commented Dec 7, 2023

@wdconinc yes we should backport that sort of security fix.

@spackbot-app spackbot-app bot added stand-alone-tests Stand-alone (or smoke) tests for installed packages utilities labels Jan 2, 2024
Stephen Sachs and others added 7 commits January 2, 2024 11:08
This was missed while backporting the new `spack info` command from #40326.

Variants should be sorted by name when invoking `spack info --variants-by-name`.
* solver: use a unique counter for condition, triggers and effects

* Do not reset counters when re-running setup

  What we need is just a unique ID, it doesn't need
  to start from zero every time.
This commit discards type mismatches or failures to validate a package preference during concretization. The values discarded are logged as debug level messages. It also adds a config audit to help users spot misconfigurations in packages.yaml preferences.
* update url for BerkeleyGW version 3.0.1
* update source urls and add version 3.1.0 to berkeleygw package
…#41986)

This fixes an issue where pkg.stage throws because a patch cannot be found,
but the patch is redundant because the spec is reused from a build cache and
will be installed from existing binaries.
@haampie haampie force-pushed the backports/v0.21.1 branch 2 times, most recently from e42f167 to 48936c8 Compare January 10, 2024 13:35
Add forward compatibility for tarballs created by Spack 0.22, which
use build cache layout version 2.

Spack 0.21 continues to produce build cache layout version 1 tarballs.

Build cache layout version 2 also lists parent directories of the
package prefix in the tarball, which is required for certain container
runtimes.
@alalazo alalazo merged commit db7bc67 into releases/v0.21 Jan 10, 2024
@alalazo alalazo deleted the backports/v0.21.1 branch January 10, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backports binary-packages build-environment commands compilers core PR affects Spack core functionality dependencies documentation Improvements or additions to documentation new-variant new-version patch python stand-alone-tests Stand-alone (or smoke) tests for installed packages tests General test capability(ies) update-package utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants