Merged
Conversation
5d7c9bb to
79fc0cd
Compare
Member
|
It would be nice if we could also backport #41126 since the aliases example in the release notes is currently broken. |
…1107) * Add audit check to spot when= arguments using named specs * Fix package issues caught by the new audit
Improves the warning for deprecated preferences, and adds a configuration audit to get files:lines details of the issues. Co-authored-by: Tamara Dahlgren <[email protected]>
Member
Author
|
@michaelkuhn Feel free to add to the list above! |
When improving the error message, we started #showing in the answer set a lot more symbols - but we forgot to suppress the debug messages warning about UNKNOWN SYMBOLs
This roughly restores the order of operation from Spack 0.20, where where `AutotoolsPackage.setup_build_environment` would override the env variable set in `setup_platform_environment` on macOS.
Co-authored-by: Harmen Stoppels <[email protected]>
If we use all specs, we won't color correctly build-only dependencies
PR #40929 reverted the argument parsing to make `spack --verbose install` work again. It looks like `--verbose` is the only instance where this kind of argument inheritance is used since all other commands override arguments with the same name instead. For instance, `spack --bootstrap clean` does not invoke `spack clean --bootstrap`. Therefore, fix multi-line aliases again by parsing the resolved arguments and instead explicitly pass down `args.verbose` to commands.
Contributor
|
Thoughts on backporting #41404 from people here? What's the past record of backporting security issues in packages? Does that rise to the level of concern that we want it backported? If no concern here, I'll add it to the list and merge that PR. |
Member
|
@wdconinc yes we should backport that sort of security fix. |
* tests: default_config drop scope * use default_config elsewhere * use parse_install_tree for missing defaults in default config
Co-authored-by: Harmen Stoppels <[email protected]>
This was missed while backporting the new `spack info` command from #40326. Variants should be sorted by name when invoking `spack info --variants-by-name`.
* solver: use a unique counter for condition, triggers and effects * Do not reset counters when re-running setup What we need is just a unique ID, it doesn't need to start from zero every time.
This commit discards type mismatches or failures to validate a package preference during concretization. The values discarded are logged as debug level messages. It also adds a config audit to help users spot misconfigurations in packages.yaml preferences.
* update url for BerkeleyGW version 3.0.1 * update source urls and add version 3.1.0 to berkeleygw package
…#41986) This fixes an issue where pkg.stage throws because a patch cannot be found, but the patch is redundant because the spec is reused from a build cache and will be installed from existing binaries.
e42f167 to
48936c8
Compare
Add forward compatibility for tarballs created by Spack 0.22, which use build cache layout version 2. Spack 0.21 continues to produce build cache layout version 1 tarballs. Build cache layout version 2 also lists parent directories of the package prefix in the tarball, which is required for certain container runtimes.
48936c8 to
72cdfbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when=arguments using wrong named specs #41107test_which: do not mutateos.environ(#41215) #41215spack info --variants-by-name#41389