Skip to content

Fix infinite recursion when computing concretization errors#41061

Merged
alalazo merged 2 commits intospack:developfrom
alalazo:bugfix/error-chains-infinite-recursion
Nov 14, 2023
Merged

Fix infinite recursion when computing concretization errors#41061
alalazo merged 2 commits intospack:developfrom
alalazo:bugfix/error-chains-infinite-recursion

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Nov 14, 2023

fixes #41029

The main issue is that cause is a pair of integers. Using it to construct a set will create a set with 2 integers, instead of a set with a single tuple.

Modifications:

  • Fix an issue with adding elements to a set
  • Prompt a better error message for unexpected errors

@spackbot-app spackbot-app bot added the core PR affects Spack core functionality label Nov 14, 2023
Copy link
Copy Markdown
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks!

@alalazo alalazo merged commit 1255620 into spack:develop Nov 14, 2023
@alalazo alalazo deleted the bugfix/error-chains-infinite-recursion branch November 14, 2023 13:45
This was referenced Nov 14, 2023
gabrielctn pushed a commit to gabrielctn/spack that referenced this pull request Nov 24, 2023
mtaillefumier pushed a commit to mtaillefumier/spack that referenced this pull request Dec 14, 2023
wdconinc pushed a commit to eic/spack that referenced this pull request Jan 7, 2024
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 31, 2024
vjranagit pushed a commit to vjranagit/spack that referenced this pull request Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core PR affects Spack core functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visit + modern Python: maximum recursion depth exceeded

2 participants