libevent: call autoreconf directly instead of via autogen.sh#41057
Merged
alalazo merged 1 commit intospack:developfrom Nov 15, 2023
Merged
libevent: call autoreconf directly instead of via autogen.sh#41057alalazo merged 1 commit intospack:developfrom
alalazo merged 1 commit intospack:developfrom
Conversation
|
Hi @blue42u! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers("blue42u")If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame libeventThank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
alalazo
reviewed
Nov 14, 2023
blue42u
force-pushed
the
libevent-autogen-no-which
branch
from
3946efb to
e0c7691
Compare
blue42u
changed the title
alalazo
previously approved these changes
Nov 14, 2023
auto-merge was automatically disabled
November 15, 2023 06:42
Head branch was pushed to by a user without write access
blue42u
force-pushed
the
libevent-autogen-no-which
branch
from
e0c7691 to
e834226
Compare
Contributor
Author
|
Looking into the CI failure, apparently Spack's # # On ppc64le
# PATH=$(spack location -i which)/bin:$PATH which which
which: no which in (/home/software/spack/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeh/linux-ubuntu20.04-ppc64le/gcc-9.4.0/which-2.21-57arjijrsllc6tozz3mnhirvq47xpei6/bin:/opt/bootstrap/view/bin:/builds/spack/spack/bin:/opt/bootstrap/view/bin:/opt/bootstrap:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin)
# # On x86-64
# PATH=$(spack location -i which)/bin:$PATH which which
/home/software/spack/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeh/linux-ubuntu20.04-x86_64_v3/gcc-11.4.0/which-2.21-e7g4ojtne4qs2qsjnd4fyt2agwncljdm/bin/whichAside: Upon further investigation
Given the wide range of So, take three: I've adjusted the recipe to just run |
blue42u
changed the title
alalazo
approved these changes
Nov 15, 2023
gabrielctn
pushed a commit
to gabrielctn/spack
that referenced
this pull request
Nov 24, 2023
This was referenced Nov 29, 2023
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Dec 14, 2023
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
haampie
added a commit
to haampie/spack
that referenced
this pull request
Feb 28, 2024
The deps were added in spack#40945 to make it work on macOS 11, because the old configure scripts only detect macOS 10. Apparently people the autoreconf script caused issues, later fixed in spack#41057. However, also with that fix, things are incorrect, cause people now report: ``` libtool: You should recreate aclocal.m4 with macros from libtool 2.4.7 libtool: and run autoconf again. ``` I did not check what that error is about exactly, but it looks like Spack's `def autoreconf` step does way less than the `autgen.sh` script provided in the source tarball. HOWEVER, all this is unnecessary, because the underlying issue was already fixed long ago, it's just that it regressed at some point, but it's back in place since spack#41205, therefore, get rid of all this madness.
alalazo
pushed a commit
that referenced
this pull request
Feb 29, 2024
The deps were added in #40945 to make it work on macOS 11, because the old configure scripts only detect macOS 10. Apparently people reported the autoreconf script caused issues, later fixed in #41057. However, also with that fix, things are incorrect, cause people now report: ``` libtool: You should recreate aclocal.m4 with macros from libtool 2.4.7 libtool: and run autoconf again. ``` HOWEVER, all this is unnecessary, because the underlying issue was already fixed long ago, it's just that it regressed at some point, but it's back in place since #41205.
mathomp4
pushed a commit
to mathomp4/spack
that referenced
this pull request
Mar 27, 2024
The deps were added in spack#40945 to make it work on macOS 11, because the old configure scripts only detect macOS 10. Apparently people reported the autoreconf script caused issues, later fixed in spack#41057. However, also with that fix, things are incorrect, cause people now report: ``` libtool: You should recreate aclocal.m4 with macros from libtool 2.4.7 libtool: and run autoconf again. ``` HOWEVER, all this is unnecessary, because the underlying issue was already fixed long ago, it's just that it regressed at some point, but it's back in place since spack#41205.
teaguesterling
pushed a commit
to teaguesterling/spack
that referenced
this pull request
Jun 15, 2024
The deps were added in spack#40945 to make it work on macOS 11, because the old configure scripts only detect macOS 10. Apparently people reported the autoreconf script caused issues, later fixed in spack#41057. However, also with that fix, things are incorrect, cause people now report: ``` libtool: You should recreate aclocal.m4 with macros from libtool 2.4.7 libtool: and run autoconf again. ``` HOWEVER, all this is unnecessary, because the underlying issue was already fixed long ago, it's just that it regressed at some point, but it's back in place since spack#41205.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41056.
The
autogen.shscript shipped by libevent useswhichto determine ifautoreconfis available, butwhichisn't installed by default on all systems (e.g. Fedora). If Spack is building withlibtool @2.4.7this causes build failures since the libtool M4 fragments in libevent are libtool 2.4.6.This PR adds a patch to replace the use ofwhichwithcommand -v, which is a POSIX shell builtin and thus more portable.EDIT: This PR fixes this by adding a build dependency onwhich.EDIT: This PR fixes this by calling
autoreconfdirectly, instead of trying to getautogen.shto do so.