Skip to content

env: compute env mods only for installed roots#40997

Merged
alalazo merged 1 commit intospack:developfrom
haampie:fix/env-mods-partially-installed
Nov 10, 2023
Merged

env: compute env mods only for installed roots#40997
alalazo merged 1 commit intospack:developfrom
haampie:fix/env-mods-partially-installed

Conversation

@haampie
Copy link
Copy Markdown
Member

@haampie haampie commented Nov 10, 2023

And improve the error message (load vs unload).

Of course you could have some uninstalled dependency too, but as long as
it doesn't implement setup_run_environment etc, I don't think it hurts
to attempt to load the root anyways, given that failure to do so is a
warning, not a fatal error.

@spackbot-app spackbot-app bot added core PR affects Spack core functionality environments labels Nov 10, 2023
And improve the error message (load vs unload).

Of course you could have some uninstalled dependency too, but as long as
it doesn't implement `setup_run_environment` etc, I don't think it hurts
to attempt to load the root anyways, given that failure to do so is a
warning, not a fatal error.
@haampie haampie force-pushed the fix/env-mods-partially-installed branch from 3e68d62 to 2d16820 Compare November 10, 2023 10:01
@spackbot-app spackbot-app bot added commands tests General test capability(ies) labels Nov 10, 2023
@haampie haampie added this to the v0.21.0 milestone Nov 10, 2023
@alalazo alalazo self-assigned this Nov 10, 2023
@alalazo alalazo merged commit 4027a21 into spack:develop Nov 10, 2023
@haampie haampie deleted the fix/env-mods-partially-installed branch November 10, 2023 11:33
haampie added a commit that referenced this pull request Nov 10, 2023
And improve the error message (load vs unload).

Of course you could have some uninstalled dependency too, but as long as
it doesn't implement `setup_run_environment` etc, I don't think it hurts
to attempt to load the root anyways, given that failure to do so is a
warning, not a fatal error.
@haampie haampie mentioned this pull request Nov 10, 2023
10 tasks
tgamblin pushed a commit that referenced this pull request Nov 11, 2023
And improve the error message (load vs unload).

Of course you could have some uninstalled dependency too, but as long as
it doesn't implement `setup_run_environment` etc, I don't think it hurts
to attempt to load the root anyways, given that failure to do so is a
warning, not a fatal error.
gabrielctn pushed a commit to gabrielctn/spack that referenced this pull request Nov 24, 2023
And improve the error message (load vs unload).

Of course you could have some uninstalled dependency too, but as long as
it doesn't implement `setup_run_environment` etc, I don't think it hurts
to attempt to load the root anyways, given that failure to do so is a
warning, not a fatal error.
mtaillefumier pushed a commit to mtaillefumier/spack that referenced this pull request Dec 14, 2023
And improve the error message (load vs unload).

Of course you could have some uninstalled dependency too, but as long as
it doesn't implement `setup_run_environment` etc, I don't think it hurts
to attempt to load the root anyways, given that failure to do so is a
warning, not a fatal error.
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 31, 2024
And improve the error message (load vs unload).

Of course you could have some uninstalled dependency too, but as long as
it doesn't implement `setup_run_environment` etc, I don't think it hurts
to attempt to load the root anyways, given that failure to do so is a
warning, not a fatal error.
vjranagit pushed a commit to vjranagit/spack that referenced this pull request Jan 18, 2026
And improve the error message (load vs unload).

Of course you could have some uninstalled dependency too, but as long as
it doesn't implement `setup_run_environment` etc, I don't think it hurts
to attempt to load the root anyways, given that failure to do so is a
warning, not a fatal error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commands core PR affects Spack core functionality environments tests General test capability(ies)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants