libevent: always autogen.sh by tvandera · Pull Request #40945 · spack/spack

tvandera · 2023-11-08T13:29:38Z

The libevent release tarballs ship with a configure script generated by an old libtool. The libtool generated by configure is not compatible with MACOSX_DEPLOYMENT_VERSION > 10. Regeneration of the configure scripts fixes build on macOS.

Original configure contains:

    case $host_os in
    rhapsody* | darwin1.[012])
      _lt_dar_allow_undefined='$wl-undefined ${wl}suppress' ;;
    darwin1.*)
      _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined ${wl}suppress' ;;
    darwin*) # darwin 5.x on
      # if running on 10.5 or later, the deployment target defaults
      # to the OS version, if on x86, and 10.4, the deployment
      # target defaults to 10.4. Don't you love it?
      case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
        10.0,*86*-darwin8*|10.0,*-darwin[91]*)
          _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup' ;;
        10.[012][,.]*)
          _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined ${wl}suppress' ;;
        10.*)
          _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup' ;;
      esac

After re-running autogen.sh:

    case $host_os in
    rhapsody* | darwin1.[012])
      _lt_dar_allow_undefined='$wl-undefined ${wl}suppress' ;;
    darwin1.*)
      _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined ${wl}suppress' ;;
    darwin*)
      case $MACOSX_DEPLOYMENT_TARGET,$host in
        10.[012],*|,*powerpc*-darwin[5-8]*)
          _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined ${wl}suppress' ;;
        *)
          _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup' ;;
      esac

spackbot-app · 2023-11-08T13:29:47Z

Hi @tvandera! I noticed that the following package(s) don't yet have maintainers:

libevent

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("tvandera")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame libevent

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

alecbcs

@tvandera this PR looks great! Just one quick nitpick to allow for more compatibility in distributions where bash isn't in their base image. If you'd really like to enforce using bash I'd suggest adding it as a dependency of the package.

var/spack/repos/builtin/packages/libevent/package.py

haampie · 2023-11-08T21:05:17Z

Does this by chance solve

libtool: link: /Users/gitlab-runner-p-0/builds/6zjf6TwE/0/spack/spack/lib/spack/env/clang/clang -dynamiclib  -o .libs/libevent_pthreads-2.1.7.dylib  .libs/evthread_pthread.o    -g -O2   -install_name  /Users/gitlab-runner-p-0/builds/6zjf6TwE/0/spack/spack/opt/spack/[padded-to-256-chars]/darwin-ventura-aarch64/apple-clang-15.0.0/libevent-2.1.12-mxdxqw23bzsk5fditk6kjgzwdekzzmqw/lib/libevent_pthreads-2.1.7.dylib -compatibility_version 8 -current_version 8.1 
ld: Undefined symbols:
  _event_mm_free_, referenced from:
      _evthread_posix_lock_alloc in evthread_pthread.o
      _evthread_posix_lock_free in evthread_pthread.o
      _evthread_posix_cond_alloc in evthread_pthread.o
      _evthread_posix_cond_free in evthread_pthread.o
  _event_mm_malloc_, referenced from:
      _evthread_posix_lock_alloc in evthread_pthread.o
      _evthread_posix_cond_alloc in evthread_pthread.o
  _evthread_set_condition_callbacks, referenced from:
      _evthread_use_pthreads in evthread_pthread.o
  _evthread_set_id_callback, referenced from:
      _evthread_use_pthreads in evthread_pthread.o
  _evthread_set_lock_callbacks, referenced from:
      _evthread_use_pthreads in evthread_pthread.o

I'm not on a mac right now, but seen this failure in CI.

Co-authored-by: Alec Scott <[email protected]>

haampie

This was a timely fix, thank you!

tvandera · 2023-11-08T21:09:45Z

Does this by chance solve

libtool: link: /Users/gitlab-runner-p-0/builds/6zjf6TwE/0/spack/spack/lib/spack/env/clang/clang -dynamiclib  -o .libs/libevent_pthreads-2.1.7.dylib  .libs/evthread_pthread.o    -g -O2   -install_name  /Users/gitlab-runner-p-0/builds/6zjf6TwE/0/spack/spack/opt/spack/[padded-to-256-chars]/darwin-ventura-aarch64/apple-clang-15.0.0/libevent-2.1.12-mxdxqw23bzsk5fditk6kjgzwdekzzmqw/lib/libevent_pthreads-2.1.7.dylib -compatibility_version 8 -current_version 8.1 
ld: Undefined symbols:

I'm not on a mac right now, but seen this failure in CI.

Yes. That was why I started looking into it.

haampie · 2023-11-08T21:11:45Z

Great, it was the only failure in CI on the releases/v0.21 branch, so will "backport" it there. Thanks a lot 👍

The libevent release tarballs ship with a `configure` script generated by an old `libtool`. The `libtool` generated by `configure` is not compatible with `MACOSX_DEPLOYMENT_VERSION` > 10. Regeneration of the `configure` scripts fixes build on macOS. Original configure contains: ``` case $host_os in rhapsody* | darwin1.[012]) _lt_dar_allow_undefined='$wl-undefined ${wl}suppress' ;; darwin1.*) _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined ${wl}suppress' ;; darwin*) # darwin 5.x on # if running on 10.5 or later, the deployment target defaults # to the OS version, if on x86, and 10.4, the deployment # target defaults to 10.4. Don't you love it? case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in 10.0,*86*-darwin8*|10.0,*-darwin[91]*) _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup' ;; 10.[012][,.]*) _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined ${wl}suppress' ;; 10.*) _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup' ;; esac ``` After re-running `autogen.sh`: ``` case $host_os in rhapsody* | darwin1.[012]) _lt_dar_allow_undefined='$wl-undefined ${wl}suppress' ;; darwin1.*) _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined ${wl}suppress' ;; darwin*) case $MACOSX_DEPLOYMENT_TARGET,$host in 10.[012],*|,*powerpc*-darwin[5-8]*) _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined ${wl}suppress' ;; *) _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup' ;; esac ```

The deps were added in spack#40945 to make it work on macOS 11, because the old configure scripts only detect macOS 10. Apparently people the autoreconf script caused issues, later fixed in spack#41057. However, also with that fix, things are incorrect, cause people now report: ``` libtool: You should recreate aclocal.m4 with macros from libtool 2.4.7 libtool: and run autoconf again. ``` I did not check what that error is about exactly, but it looks like Spack's `def autoreconf` step does way less than the `autgen.sh` script provided in the source tarball. HOWEVER, all this is unnecessary, because the underlying issue was already fixed long ago, it's just that it regressed at some point, but it's back in place since spack#41205, therefore, get rid of all this madness.

The deps were added in #40945 to make it work on macOS 11, because the old configure scripts only detect macOS 10. Apparently people reported the autoreconf script caused issues, later fixed in #41057. However, also with that fix, things are incorrect, cause people now report: ``` libtool: You should recreate aclocal.m4 with macros from libtool 2.4.7 libtool: and run autoconf again. ``` HOWEVER, all this is unnecessary, because the underlying issue was already fixed long ago, it's just that it regressed at some point, but it's back in place since #41205.

The deps were added in spack#40945 to make it work on macOS 11, because the old configure scripts only detect macOS 10. Apparently people reported the autoreconf script caused issues, later fixed in spack#41057. However, also with that fix, things are incorrect, cause people now report: ``` libtool: You should recreate aclocal.m4 with macros from libtool 2.4.7 libtool: and run autoconf again. ``` HOWEVER, all this is unnecessary, because the underlying issue was already fixed long ago, it's just that it regressed at some point, but it's back in place since spack#41205.

The libevent release tarballs ship with a `configure` script generated by an old `libtool`. The `libtool` generated by `configure` is not compatible with `MACOSX_DEPLOYMENT_VERSION` > 10. Regeneration of the `configure` scripts fixes build on macOS. Original configure contains: ``` case $host_os in rhapsody* | darwin1.[012]) _lt_dar_allow_undefined='$wl-undefined ${wl}suppress' ;; darwin1.*) _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined ${wl}suppress' ;; darwin*) # darwin 5.x on # if running on 10.5 or later, the deployment target defaults # to the OS version, if on x86, and 10.4, the deployment # target defaults to 10.4. Don't you love it? case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in 10.0,*86*-darwin8*|10.0,*-darwin[91]*) _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup' ;; 10.[012][,.]*) _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined ${wl}suppress' ;; 10.*) _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup' ;; esac ``` After re-running `autogen.sh`: ``` case $host_os in rhapsody* | darwin1.[012]) _lt_dar_allow_undefined='$wl-undefined ${wl}suppress' ;; darwin1.*) _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined ${wl}suppress' ;; darwin*) case $MACOSX_DEPLOYMENT_TARGET,$host in 10.[012],*|,*powerpc*-darwin[5-8]*) _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined ${wl}suppress' ;; *) _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup' ;; esac ```

The deps were added in spack#40945 to make it work on macOS 11, because the old configure scripts only detect macOS 10. Apparently people reported the autoreconf script caused issues, later fixed in spack#41057. However, also with that fix, things are incorrect, cause people now report: ``` libtool: You should recreate aclocal.m4 with macros from libtool 2.4.7 libtool: and run autoconf again. ``` HOWEVER, all this is unnecessary, because the underlying issue was already fixed long ago, it's just that it regressed at some point, but it's back in place since spack#41205.

The libevent release tarballs ship with a `configure` script generated by an old `libtool`. The `libtool` generated by `configure` is not compatible with `MACOSX_DEPLOYMENT_VERSION` > 10. Regeneration of the `configure` scripts fixes build on macOS. Original configure contains: ``` case $host_os in rhapsody* | darwin1.[012]) _lt_dar_allow_undefined='$wl-undefined ${wl}suppress' ;; darwin1.*) _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined ${wl}suppress' ;; darwin*) # darwin 5.x on # if running on 10.5 or later, the deployment target defaults # to the OS version, if on x86, and 10.4, the deployment # target defaults to 10.4. Don't you love it? case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in 10.0,*86*-darwin8*|10.0,*-darwin[91]*) _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup' ;; 10.[012][,.]*) _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined ${wl}suppress' ;; 10.*) _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup' ;; esac ``` After re-running `autogen.sh`: ``` case $host_os in rhapsody* | darwin1.[012]) _lt_dar_allow_undefined='$wl-undefined ${wl}suppress' ;; darwin1.*) _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined ${wl}suppress' ;; darwin*) case $MACOSX_DEPLOYMENT_TARGET,$host in 10.[012],*|,*powerpc*-darwin[5-8]*) _lt_dar_allow_undefined='$wl-flat_namespace $wl-undefined ${wl}suppress' ;; *) _lt_dar_allow_undefined='$wl-undefined ${wl}dynamic_lookup' ;; esac ```

spackbot-app bot added dependencies update-package labels Nov 8, 2023

libevent: always autogen.sh

d6c90bc

tvandera force-pushed the libevent-autogen branch from 416eef2 to d6c90bc Compare November 8, 2023 13:37

alecbcs requested changes Nov 8, 2023

View reviewed changes

var/spack/repos/builtin/packages/libevent/package.py Show resolved Hide resolved

alecbcs self-assigned this Nov 8, 2023

libevent: do not depend on bash to run autogen.sh

15b627e

Co-authored-by: Alec Scott <[email protected]>

haampie approved these changes Nov 8, 2023

View reviewed changes

haampie added this to the v0.21.0 milestone Nov 8, 2023

haampie enabled auto-merge (squash) November 8, 2023 21:17

haampie disabled auto-merge November 8, 2023 21:32

haampie merged commit c35250b into spack:develop Nov 8, 2023

haampie mentioned this pull request Nov 8, 2023

Backports v0.21.0 (2) #40943

Merged

8 tasks

tvandera deleted the libevent-autogen branch November 8, 2023 21:51

haampie mentioned this pull request Feb 28, 2024

libevent: remove autotools build deps again #42908

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libevent: always autogen.sh#40945

libevent: always autogen.sh#40945
haampie merged 2 commits intospack:developfrom
tvandera:libevent-autogen

tvandera commented Nov 8, 2023 •

edited

Loading

Uh oh!

spackbot-app bot commented Nov 8, 2023

Uh oh!

alecbcs left a comment

Uh oh!

Uh oh!

haampie commented Nov 8, 2023

Uh oh!

haampie left a comment

Uh oh!

tvandera commented Nov 8, 2023 •

edited

Loading

Uh oh!

haampie commented Nov 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

tvandera commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spackbot-app bot commented Nov 8, 2023

Uh oh!

alecbcs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

haampie commented Nov 8, 2023

Uh oh!

haampie left a comment

Choose a reason for hiding this comment

Uh oh!

tvandera commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

haampie commented Nov 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tvandera commented Nov 8, 2023 •

edited

Loading

tvandera commented Nov 8, 2023 •

edited

Loading