Revert python build isolation & setuptools source install#40796
Merged
haampie merged 4 commits intospack:developfrom Nov 1, 2023
Merged
Revert python build isolation & setuptools source install#40796haampie merged 4 commits intospack:developfrom
haampie merged 4 commits intospack:developfrom
Conversation
spackbot-app
bot
added
build-systems
conflicts
core
haampie
force-pushed
the
revert/python-build-isolation
branch
from
786b675 to
afe43ff
Compare
haampie
force-pushed
the
revert/python-build-isolation
branch
from
afe43ff to
9baf053
Compare
haampie
force-pushed
the
revert/python-build-isolation
branch
from
9baf053 to
85f8f9a
Compare
haampie
force-pushed
the
revert/python-build-isolation
branch
from
85f8f9a to
8f226a8
Compare
Co-authored-by: Adam J. Stewart <[email protected]>
adamjstewart
approved these changes
Oct 31, 2023
gabrielctn
pushed a commit
to gabrielctn/spack
that referenced
this pull request
Nov 24, 2023
* Revert "Improve build isolation in PythonPipBuilder (spack#40224)" This reverts commit 0f43074. * Revert "py-setuptools: sdist + rpath patch backport (spack#40205)" This reverts commit 512e41a.
This was referenced Nov 29, 2023
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Dec 14, 2023
* Revert "Improve build isolation in PythonPipBuilder (spack#40224)" This reverts commit 0f43074. * Revert "py-setuptools: sdist + rpath patch backport (spack#40205)" This reverts commit 512e41a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PythonPipBuilder#40224)"The venv for build isolation is causing issues on Debian due to a different install layout of packages when Python is run from a venv vs from the underlying system executable: PYTHONPATH at runtime is computed incorrectly.
Current decision is to revert this and go back to the old broken state of things for 0.21, and get a proper fix in after the release, as outlined in #40773.