Skip to content

Change container labeling so that "latest" is the latest tag#40593

Merged
haampie merged 4 commits intospack:developfrom
alalazo:maintaners/docker-image-tags
Nov 7, 2023
Merged

Change container labeling so that "latest" is the latest tag#40593
haampie merged 4 commits intospack:developfrom
alalazo:maintaners/docker-image-tags

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Oct 18, 2023

fixes #38816

This PR uses the docker/metadata-action to label container images. The end result is that:

  • Nightly Docker images from the develop branch will be tagged as :develop and :nightly
  • The :latest tag will be associated with the latest stable release
  • Releases will be tagged with :{major}, :{major}.{minor} and :{major}.{minor}.{patch}

This also removes ubuntu:18.04 from the list of generated Docker images.

@spackbot-app spackbot-app bot added core PR affects Spack core functionality workflow labels Oct 18, 2023
@tgamblin tgamblin requested a review from haampie November 6, 2023 18:31
@haampie
Copy link
Copy Markdown
Member

haampie commented Nov 7, 2023

Looks correct reading the docs

@haampie haampie added this to the v0.21.0 milestone Nov 7, 2023
@haampie haampie merged commit c232bf4 into spack:develop Nov 7, 2023
@alalazo alalazo deleted the maintaners/docker-image-tags branch November 7, 2023 10:54
@marcodelapierre
Copy link
Copy Markdown
Member

@alalazo is there going to be an image matching the approx weekly develop snapshot releases of Spack?

I.e. is it going to be :

  • develop image tags for the weekly snapshots
  • nightly image tags on a daily basis?

Thank you

@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Nov 14, 2023

@marcodelapierre Currently :nightly and :develop are synonyms for a daily image taken on the develop branch.

gabrielctn pushed a commit to gabrielctn/spack that referenced this pull request Nov 24, 2023
…0593)

* Use `major.minor.patch`, `major.minor`, `major` in tags

* Ensure `latest` is the semver largest version, and not "latest in time"

* Remove Ubuntu 18.04 from the list of images
mtaillefumier pushed a commit to mtaillefumier/spack that referenced this pull request Dec 14, 2023
…0593)

* Use `major.minor.patch`, `major.minor`, `major` in tags

* Ensure `latest` is the semver largest version, and not "latest in time"

* Remove Ubuntu 18.04 from the list of images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core PR affects Spack core functionality workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stable container tag for rolling develop

4 participants