Merged
Conversation
adamjstewart
approved these changes
Apr 29, 2017
junghans
commented
Apr 29, 2017
| depends_on("[email protected]:", type='build') | ||
| depends_on("flecsi~mpi", when='~mpi') | ||
| depends_on("flecsi+mpi", when='+mpi') | ||
| depends_on("python@2:2.8") |
Contributor
Author
There was a problem hiding this comment.
Yes, python2 only (see laristra/flecsale#39)
| options = [ | ||
| '-DENABLE_UNIT_TESTS=ON' | ||
| '-DENABLE_OPENSSL=ON' | ||
| '-DENABLE_PYTHON=ON' |
Member
There was a problem hiding this comment.
These lines are causing the flake8 tests to fail. They should be indented by 4 spaces, not 8.
junghans
force-pushed
the
features/flecsale
branch
from
9334e94 to
51d388c
Compare
diaena
pushed a commit
to diaena/spack
that referenced
this pull request
May 26, 2017
xavierandrade
pushed a commit
to xavierandrade/spack
that referenced
this pull request
Jun 16, 2017
EmreAtes
pushed a commit
to EmreAtes/spack
that referenced
this pull request
Jul 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.