Fix version incompatibilities of py-pandas and py-openpyxl#40472
Merged
adamjstewart merged 13 commits intospack:developfrom Oct 16, 2023
Merged
Fix version incompatibilities of py-pandas and py-openpyxl#40472adamjstewart merged 13 commits intospack:developfrom
adamjstewart merged 13 commits intospack:developfrom
Conversation
adamjstewart
requested changes
Oct 12, 2023
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
openpyxl isn't a required dep of pandas. You could add an +excel variant that installs the 5 other deps needed, or you could just allow the user to install it afterwards.
Contributor
Author
We need to make sure that openpyxl is recent enough, whichever way gets us there and is the easiest. Happy to create a excel variant if you think this is the easiest solution. |
Member
|
I think a variant that defaults to False is the appropriate way. |
Contributor
Author
Done, please check. Thanks! |
adamjstewart
previously approved these changes
Oct 16, 2023
Member
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
adamjstewart
approved these changes
Oct 16, 2023
|
I was able to run spack style --fix==> Running style checks on spack
selected: isort, black, flake8, mypy
==> Modified files
var/spack/repos/builtin/packages/py-odfpy/package.py
var/spack/repos/builtin/packages/py-pandas/package.py
var/spack/repos/builtin/packages/py-pyxlsb/package.py
var/spack/repos/builtin/packages/py-xlsxwriter/package.py
==> Running isort checks
isort checks were clean
==> Running black checks
All done! ✨ 🍰 ✨
4 files left unchanged.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> Running mypy checks
Success: no issues found in 588 source files
mypy checks were clean
==> spack style checks were clean
I wasn't able to make any further changes, but please see the message above for remaining issues you can fix locally! |
3 tasks
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Oct 23, 2023
* Fix version incompatibilities of py-pandas and py-openpyxl * Add variant excel for py-pandas * Add package py-pyxlsb * Add versios for py-xlsxwriter * Define excel dependencies for py-pandas 1.4, 1.5, 2.0, 2.1 * Fix variant excel in py-pandas * Add package py-odfpy, which is also a dependency for [email protected]: * Rearrange excel dependencies for py-pandas * Change url to pypi * Add missing newline to fix style in py-odfpy
victoria-cherkas
pushed a commit
to victoria-cherkas/spack
that referenced
this pull request
Oct 30, 2023
* Fix version incompatibilities of py-pandas and py-openpyxl * Add variant excel for py-pandas * Add package py-pyxlsb * Add versios for py-xlsxwriter * Define excel dependencies for py-pandas 1.4, 1.5, 2.0, 2.1 * Fix variant excel in py-pandas * Add package py-odfpy, which is also a dependency for [email protected]: * Rearrange excel dependencies for py-pandas * Change url to pypi * Add missing newline to fix style in py-odfpy
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Nov 2, 2023
* Fix version incompatibilities of py-pandas and py-openpyxl * Add variant excel for py-pandas * Add package py-pyxlsb * Add versios for py-xlsxwriter * Define excel dependencies for py-pandas 1.4, 1.5, 2.0, 2.1 * Fix variant excel in py-pandas * Add package py-odfpy, which is also a dependency for [email protected]: * Rearrange excel dependencies for py-pandas * Change url to pypi * Add missing newline to fix style in py-odfpy
gabrielctn
pushed a commit
to gabrielctn/spack
that referenced
this pull request
Nov 24, 2023
* Fix version incompatibilities of py-pandas and py-openpyxl * Add variant excel for py-pandas * Add package py-pyxlsb * Add versios for py-xlsxwriter * Define excel dependencies for py-pandas 1.4, 1.5, 2.0, 2.1 * Fix variant excel in py-pandas * Add package py-odfpy, which is also a dependency for [email protected]: * Rearrange excel dependencies for py-pandas * Change url to pypi * Add missing newline to fix style in py-odfpy
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Dec 14, 2023
* Fix version incompatibilities of py-pandas and py-openpyxl * Add variant excel for py-pandas * Add package py-pyxlsb * Add versios for py-xlsxwriter * Define excel dependencies for py-pandas 1.4, 1.5, 2.0, 2.1 * Fix variant excel in py-pandas * Add package py-odfpy, which is also a dependency for [email protected]: * Rearrange excel dependencies for py-pandas * Change url to pypi * Add missing newline to fix style in py-odfpy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue reported in #40452.
To fix that, based on @adamjstewart's suggestions, I added an
excelvariant that adds five optional dependencies topy-pandas. I checked the pandas releases 1.4, 1.5, 2.0, 2.1 and defined those optional dependencies for Excel in the package. I defined the variantexcelonly for those versions ofpy-pandas, because it's likely a waste of my time to code this up for ancient versions. I checked the five dependencies, two didn't exist yet (py-pyxlsb,py-odfpy), which I added, and one needed additional versions to satisfy the requirements (py-xlsxwriter).I tested this for version 1.5.3 on my macOS, and it all installed fine.
Closes #40452