Skip to content

spider: respect <base> tag#40443

Merged
alecbcs merged 1 commit intospack:developfrom
haampie:fix/spider-respect-base-tag
Oct 11, 2023
Merged

spider: respect <base> tag#40443
alecbcs merged 1 commit intospack:developfrom
haampie:fix/spider-respect-base-tag

Conversation

@haampie
Copy link
Copy Markdown
Member

@haampie haampie commented Oct 11, 2023

For example this URL:

https://curl.se/download/

has a base tag

<base href="https://curl.se">

so that relative URLs in links like

<a href="download/curl-8.4.0.tar.xz">2.54MB</a>

resolve to

https://curl.se/download/curl-8.4.0.tar.xz

not

https://curl.se/download/download/curl-8.4.0.tar.xz

like Spack currently does.

@spackbot-app spackbot-app bot added core PR affects Spack core functionality fetching utilities labels Oct 11, 2023
@haampie haampie requested review from alalazo and alecbcs October 11, 2023 08:54
Copy link
Copy Markdown
Member

@alecbcs alecbcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Have also experienced this on a couple of sites so this is a great fix @haampie!

@alecbcs alecbcs merged commit 65e7ec0 into spack:develop Oct 11, 2023
mtaillefumier pushed a commit to mtaillefumier/spack that referenced this pull request Oct 23, 2023
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Nov 2, 2023
mtaillefumier pushed a commit to mtaillefumier/spack that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core PR affects Spack core functionality fetching utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants