py-setuptools: from wheel to source package, and backport rpath patch#40205
Merged
adamjstewart merged 1 commit intospack:developfrom Oct 8, 2023
Merged
Conversation
haampie
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
haampie
force-pushed
the
py-setuptools/backport-distutils-rpath-flag-patch
branch
5 times, most recently
from
ae7f10d to
4006b19
Compare
haampie
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Not opposed to going back to sdist but want to get @alalazo's thoughts first. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
haampie
force-pushed
the
py-setuptools/backport-distutils-rpath-flag-patch
branch
from
03f11fb to
b137908
Compare
haampie
force-pushed
the
py-setuptools/backport-distutils-rpath-flag-patch
branch
from
b137908 to
0ff077d
Compare
Member
Author
|
Rebased this after #40224 |
adamjstewart
approved these changes
Oct 8, 2023
Member
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
haampie
added a commit
to haampie/spack
that referenced
this pull request
Oct 31, 2023
This reverts commit 512e41a.
haampie
added a commit
that referenced
this pull request
Nov 1, 2023
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Nov 2, 2023
gabrielctn
pushed a commit
to gabrielctn/spack
that referenced
this pull request
Nov 24, 2023
* Revert "Improve build isolation in PythonPipBuilder (spack#40224)" This reverts commit 0f43074. * Revert "py-setuptools: sdist + rpath patch backport (spack#40205)" This reverts commit 512e41a.
haampie
deleted the
py-setuptools/backport-distutils-rpath-flag-patch
branch
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Dec 14, 2023
* Revert "Improve build isolation in PythonPipBuilder (spack#40224)" This reverts commit 0f43074. * Revert "py-setuptools: sdist + rpath patch backport (spack#40205)" This reverts commit 512e41a.
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 11, 2024
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that #40224 is merged, we can turn setuptools into a source
package again, so that the
rpathpatch that we had on Python itselffor version <= 3.11 can be applied to distutils vendored by setuptools.