Skip to content

Remove distutils dependency in Spack#40153

Merged
haampie merged 2 commits intospack:developfrom
haampie:fix/distutils-dep-in-spack
Sep 22, 2023
Merged

Remove distutils dependency in Spack#40153
haampie merged 2 commits intospack:developfrom
haampie:fix/distutils-dep-in-spack

Conversation

@haampie
Copy link
Copy Markdown
Member

@haampie haampie commented Sep 22, 2023

msvc.py: don't import distutils

Introduced in #27021, makes Spack forward incompatible with Python.

The module was already deprecated at the time of the PR.

The spack package is updated to reflect the incompatibility.

Introduced in spack#27021, makes Spack forward incompatible with Python.

The module was already deprecated at the time of the PR.
@spackbot-app spackbot-app bot added compilers core PR affects Spack core functionality dependencies update-package labels Sep 22, 2023
@haampie haampie added this to the v0.20.2 milestone Sep 22, 2023
Copy link
Copy Markdown
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need to remove the dependency on distutils

@haampie haampie merged commit 7161969 into spack:develop Sep 22, 2023
@haampie haampie deleted the fix/distutils-dep-in-spack branch September 22, 2023 11:05
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Sep 25, 2023
* msvc.py: don't import distutils

Introduced in spack#27021, makes Spack forward incompatible with Python.

The module was already deprecated at the time of the PR.

* update spack package
AdhocMan pushed a commit to AdhocMan/spack that referenced this pull request Oct 10, 2023
* msvc.py: don't import distutils

Introduced in spack#27021, makes Spack forward incompatible with Python.

The module was already deprecated at the time of the PR.

* update spack package
mtaillefumier pushed a commit to mtaillefumier/spack that referenced this pull request Oct 11, 2023
* msvc.py: don't import distutils

Introduced in spack#27021, makes Spack forward incompatible with Python.

The module was already deprecated at the time of the PR.

* update spack package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compilers core PR affects Spack core functionality dependencies update-package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants