Skip to content

OpenBLAS: add v0.3.24#40132

Merged
alalazo merged 2 commits intospack:developfrom
adamjstewart:packages/openblas
Sep 22, 2023
Merged

OpenBLAS: add v0.3.24#40132
alalazo merged 2 commits intospack:developfrom
adamjstewart:packages/openblas

Conversation

@adamjstewart
Copy link
Copy Markdown
Member

No description provided.

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Sep 21, 2023

Hi @adamjstewart! I noticed that the following package(s) don't yet have maintainers:

  • openblas

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("adamjstewart")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame openblas

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@adamjstewart
Copy link
Copy Markdown
Member Author

@spackbot fix style

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Sep 21, 2023

Let me see if I can fix that for you!

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Sep 21, 2023

I was able to run spack style --fix for you!

spack style --fix
==> Running style checks on spack
  selected: isort, black, flake8, mypy
==> Modified files
  var/spack/repos/builtin/packages/openblas/package.py
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/openblas/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
Success: no issues found in 586 source files
  mypy checks were clean
==> spack style checks were clean
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

@alalazo alalazo merged commit 0b82039 into spack:develop Sep 22, 2023
@adamjstewart adamjstewart deleted the packages/openblas branch September 22, 2023 08:22
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Sep 25, 2023
AdhocMan pushed a commit to AdhocMan/spack that referenced this pull request Oct 10, 2023
mtaillefumier pushed a commit to mtaillefumier/spack that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants