libzmq: fix build with Apple Clang 15.0.0#40116
Merged
haampie merged 2 commits intospack:developfrom Sep 22, 2023
Merged
Conversation
dennisklein
reviewed
Sep 20, 2023
dennisklein
approved these changes
Sep 20, 2023
Member
Author
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
dennisklein
approved these changes
Sep 21, 2023
Member
Author
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
Member
^^ |
haampie
approved these changes
Sep 22, 2023
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Sep 25, 2023
AdhocMan
pushed a commit
to AdhocMan/spack
that referenced
this pull request
Oct 10, 2023
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple Clang 15.0.0 also enables C++16 by default, causing many of the same issues GCC 13 did. Instead of iterating over all possible compilers, we should always apply all patches. These patches were merged into master because the developers trusted them not to break other compilers.