lammps: simplify url_for_version logic#39554
Merged
bernhardkaindl merged 1 commit intospack:developfrom Aug 24, 2023
Merged
Conversation
now uses the stable_versions set to check whether a given version should download a "stable" tarball.
tldahlgren
reviewed
Aug 21, 2023
Contributor
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
Confirmed all 66 version sha256 with the change.
tldahlgren
reviewed
Aug 21, 2023
dyokelson
pushed a commit
to dyokelson/spack
that referenced
this pull request
Aug 24, 2023
Use the stable_versions variable to check stable versions
mpokorny
pushed a commit
to mpokorny/spack
that referenced
this pull request
Sep 18, 2023
Use the stable_versions variable to check stable versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now uses the
stable_versionsset to check whether a given version should download a "stable" tarball.