ASP-based solver: use edge properties for reused specs#39508
ASP-based solver: use edge properties for reused specs#39508tgamblin merged 1 commit intospack:developfrom
Conversation
Since spack#34821 we are annotating virtual dependencies on DAG edges, and reconstructing virtuals in mempry when we read a concrete spec from previous formats. Therefore, we can remove a TODO in asp.py, and rely on "virtual_on_edge" facts to be imposed.
spackbot-app
bot
added
core
|
@eugeneswalker This was introduced as part of #36990 to fix both #36847 and #34108, but we didn't add regression tests due to the complexity required for that (install / create a buildcache + delete a package from known repo + refresh repo caches etc). I tried to confirm manually (by locally installing a few packages and then removing providers they use from |
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
I tested this against the types of issues we saw with #36847 and #34108 and I can't detect any regression! Thanks! |
|
Ok, with @eugeneswalker's test and the work done in 9140e44 to reconstruct virtuals from old format specs, I think we're good here. |
Since spack#34821 we are annotating virtual dependencies on DAG edges, and reconstructing virtuals in memory when we read a concrete spec from previous formats. Therefore, we can remove a TODO in asp.py, and rely on "virtual_on_edge" facts to be imposed.
3 participants
Since #34821 we are annotating virtual dependencies on DAG edges, and reconstructing virtuals in memory when we read a concrete spec from previous formats.
Therefore, we can remove a TODO in asp.py, and rely on "virtual_on_edge" facts to be imposed.