Include t8code package#39391
Merged
bernhardkaindl merged 2 commits intospack:developfrom Aug 23, 2023
Merged
Conversation
spackbot-app
bot
added
dependencies
maintainers
new-package
new-variant
new-version
labels
Contributor
Hi, I looked into this together with @svengoldberg and I'm fine with it (of course). |
bernhardkaindl
force-pushed
the
t8code_package
branch
from
ebc83f3 to
38791bb
Compare
bernhardkaindl
approved these changes
Aug 23, 2023
Contributor
There was a problem hiding this comment.
Reviewed, looks good. I applied minor updates:
- Rebased to the current develop
I'm hoping that this might get the readthedocs CI task working on the 2nd attempt. - Use 'spec = self.spec' to abbreviate
self.specas is custom practise - Use f-strings as these are fair game now to enjoy.
Tested with:
bin/spack install t8code +netcdf +metis +petscI could not test +vtk because vtk failed to build with
The variable
SEACASIoss_INCLUDE_DIRSwas expected to have been available
but this is an error in vtk, not t8code.
mpokorny
pushed a commit
to mpokorny/spack
that referenced
this pull request
Sep 18, 2023
* t8code: Create new spack package Co-authored-by: Bernhard Kaindl <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a new spack package for t8code, a library to manage parallel adaptive meshes with various element types.
Thanks for reviewing in advance!