Revert "package import: remove magic import line"#39380
Merged
Conversation
This reverts commit 8e7c53a.
spackbot-app
bot
added
build-environment
core
Member
Author
|
Note also that this wasn't mentioned at #30634 |
Member
|
We could turn it into the equivalent of for 0.21 and remove it in 0.22 |
alalazo
approved these changes
Aug 10, 2023
Member
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
Fine with me if we want to proceed first with a warning. Another alternative would be to give users a command to update the package.py files automatically and print it clearly in the error message.
harshula
added a commit
to ACCESS-NRI/access-spack-packages
that referenced
this pull request
Feb 12, 2024
* Spack is planning on removing the implicit import of spack.package. See spack/spack#39380 * Recommended changes from the code review have been add. See #21
harshula
added a commit
to ACCESS-NRI/access-spack-packages
that referenced
this pull request
Feb 13, 2024
* Spack is planning on removing the implicit import of spack.package. See spack/spack#39380 * Recommended changes from the code review have been add. See #21
harshula
added a commit
to ACCESS-NRI/access-spack-packages
that referenced
this pull request
Feb 14, 2024
* Spack is planning on removing the implicit import of spack.package. See spack/spack#39380 * Recommended changes from the code review have been added. See #21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #39183
I'm in favor of this change but I think we need to revert it until there is an easy path to NOT break people who have external repositories.
2/3 of our users have external package repositories, according to our survey. Many of them have been using them since before 0.19. While we did deprecate this, we didn't warn users about this change -- i.e. we didn't actually print warnings that the functionality was going away. We need to give them a clear error message and an option to automatically fix the package files.