intel-oneapi-mkl: linking with the +cluster variant is broken for external mkl#39343
Merged
rscohn2 merged 11 commits intospack:developfrom Aug 10, 2023
Merged
Conversation
Adding `mpi` variant to deal with external oneapi-mkl usage per spack#38238.
rscohn2
previously approved these changes
Aug 8, 2023
Member
rscohn2
left a comment
rscohn2
left a comment
There was a problem hiding this comment.
Thanks for fixing this issue!
rscohn2
reviewed
Aug 8, 2023
| self.spec.satisfies(m) | ||
| for m in ["^intel-oneapi-mpi", "^intel-mpi", "^mpich", "^cray-mpich"] | ||
| ): | ||
| if self.spec.satisfies("mpi=mpich"): |
Member
There was a problem hiding this comment.
After some more thought:
this change will break the package for some existing users. Could you instead leave line 187 and add "mpi=mpich" to the list there? Same for "mpi=openmpi" below
rscohn2
previously approved these changes
Aug 8, 2023
auto-merge was automatically disabled
August 8, 2023 19:49
Head branch was pushed to by a user without write access
rscohn2
previously approved these changes
Aug 8, 2023
rscohn2
reviewed
Aug 9, 2023
Member
|
I don't understand the gitlab failure. Maybe mpi is a reserved keyword? You could change the variant name to "mpi_family" or some other name. |
Co-authored-by: Robert Cohn <[email protected]>
Member
|
I verified locally that renaming the variant to something other than mpi makes the gitlab issue go away. |
Contributor
Author
|
Thanks for verifying |
rscohn2
reviewed
Aug 9, 2023
rscohn2
previously approved these changes
Aug 9, 2023
3 tasks
rscohn2
reviewed
Aug 10, 2023
rscohn2
approved these changes
Aug 10, 2023
mpokorny
pushed a commit
to mpokorny/spack
that referenced
this pull request
Sep 18, 2023
…ernal mkl (spack#39343) * Update package.py Adding `mpi` variant to deal with external oneapi-mkl usage per spack#38238. * style conformance * accept both mpi specification mechanisms * style conformance * Update package.py * Update var/spack/repos/builtin/packages/intel-oneapi-mkl/package.py Co-authored-by: Robert Cohn <[email protected]> * rename mpi variant mpi_family * style conformance * update help message for mpi_family --------- Co-authored-by: Robert Cohn <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #38238.