Skip to content

add magma variant to strumpack#39224

Merged
tldahlgren merged 5 commits intospack:developfrom
s-sajid-ali:strumpack_magma
Aug 24, 2023
Merged

add magma variant to strumpack#39224
tldahlgren merged 5 commits intospack:developfrom
s-sajid-ali:strumpack_magma

Conversation

@s-sajid-ali
Copy link
Copy Markdown
Contributor

No description provided.

tldahlgren
tldahlgren previously approved these changes Aug 2, 2023
Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tldahlgren tldahlgren self-assigned this Aug 2, 2023
@tldahlgren tldahlgren enabled auto-merge (squash) August 2, 2023 18:56
auto-merge was automatically disabled August 2, 2023 19:06

Head branch was pushed to by a user without write access

…fails as it is ~rocm

	modified:   var/spack/repos/builtin/packages/strumpack/package.py
@s-sajid-ali
Copy link
Copy Markdown
Contributor Author

Pinging @tldahlgren for merge.

@tldahlgren tldahlgren merged commit 4b61870 into spack:develop Aug 24, 2023
@s-sajid-ali s-sajid-ali deleted the strumpack_magma branch August 24, 2023 16:53
dyokelson pushed a commit to dyokelson/spack that referenced this pull request Aug 24, 2023
* add magma variant to strumpack
* clarify conflicts to be excuive to rocm/cuda, without it +magma+cuda fails as it is ~rocm
   modified:   var/spack/repos/builtin/packages/strumpack/package.py
* add missing depends_on for magma variant
mpokorny pushed a commit to mpokorny/spack that referenced this pull request Sep 18, 2023
* add magma variant to strumpack
* clarify conflicts to be excuive to rocm/cuda, without it +magma+cuda fails as it is ~rocm
   modified:   var/spack/repos/builtin/packages/strumpack/package.py
* add missing depends_on for magma variant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants