package import: remove magic import line#39183
Merged
alalazo merged 6 commits intospack:developfrom Aug 9, 2023
Merged
Conversation
spackbot-app
bot
added
build-environment
core
alalazo
previously approved these changes
Aug 9, 2023
alalazo
reviewed
Aug 9, 2023
Co-authored-by: Massimiliano Culpo <[email protected]>
alalazo
previously approved these changes
Aug 9, 2023
alalazo
approved these changes
Aug 9, 2023
Member
|
So an issue with this one is that we've never warned about it. We did deprecate it, but I don't think we've warned users sufficiently. We really need an easy migration path, as there are likely lots of users who have packages that were created before 0.19 and don't have anything at the top. |
haampie
pushed a commit
that referenced
this pull request
Aug 11, 2023
mpokorny
pushed a commit
to mpokorny/spack
that referenced
this pull request
Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecated in #30404 (Spack v0.19.0), the opaque automatic import line can probably safely be removed by now.
To be nice, Spack suggests adding
from spack.package import *whenNameErroris raised on import.