Add amg2023 package, remove amg package#39105
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
spackbot-app
bot
added
dependencies
new-package
new-variant
new-version
update-package
labels
Co-authored-by: Riyaz Haque <[email protected]>
replace outdated amg2013 package with the current code from the amg package rename the combined package to amg2013 to avoid confusion with amg2023 rename all (1) dependency
becker33
force-pushed
the
packages/amg2023
branch
from
721742d to
c3e6475
Compare
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: isort, black, flake8, mypy
==> Modified files
var/spack/repos/builtin/packages/amg2013/package.py
var/spack/repos/builtin/packages/amg2023/package.py
var/spack/repos/builtin/packages/ecp-proxy-apps/package.py
==> Running isort checks
isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/amg2023/package.py
All done! ✨ 🍰 ✨
1 file reformatted, 2 files left unchanged.
black checks were clean
==> Running flake8 checks
var/spack/repos/builtin/packages/amg2023/package.py:59: [W605] invalid escape sequence '\s'
flake8 found errors
==> Running mypy checks
Success: no issues found in 578 source files
mypy checks were clean
I've updated the branch with style fixes. |
|
@ulrikeyang would you want to be the maintainer for this in the long term (after we get it working and into CI) or would you want someone else to manage changes to the Spack package for this? |
tldahlgren
changed the title
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
Confirmed the homepage, branch existence, and version tags though have questions about the branch naming scheme.
| sha256="b03771d84a04e3dbbbe32ba5648cd7b789e5853b938dd501e17d23d43f13c50f", | ||
| url="https://computing.llnl.gov/projects/co-design/download/amg2013.tgz", | ||
| ) | ||
| version("develop", branch="master") |
There was a problem hiding this comment.
I thought we prefer the version name to match the branch name given the comparison fix some time ago.
| an installation of hypre-2.27.0 or higher. | ||
| """ | ||
|
|
||
| tags = ["benchmark"] |
There was a problem hiding this comment.
So no longer a proxy-app even though the description is the same?
| homepage = "https://github.com/LLNL/AMG2023" | ||
| git = "https://github.com/LLNL/AMG2023.git" | ||
|
|
||
| version("develop", branch="main") |
There was a problem hiding this comment.
Same question here about the version-branch mismatch.
|
Would like to hear from @rspavel about the ecp-proxy-apps now depending on |
|
@tldahlgren @rspavel left @lanl, so we should drop him as maintainer of the proxy packages. |
Co-authored-by: Tamara Dahlgren <[email protected]>
scheibelp
left a comment
scheibelp
left a comment
There was a problem hiding this comment.
Reapproving after minor copyright change
Add amg2023 package Consolidate existing amg and amg2013 packages (they reference the same code) under the amg2013 name to minimize confusion between amg2023 and amg2013. Co-authored-by: Riyaz Haque <[email protected]>
4 participants
Add amg2023 package
Consolidate existing
amgandamg2013packages (they reference the same code) under theamg2013name to minimize confusion betweenamg2023andamg2013.