add Intel mpi package and add MPI wrappers to Intel parallel studio by davydden · Pull Request #3905 · spack/spack

davydden · 2017-04-19T12:15:46Z

as per discussion in https://groups.google.com/forum/#!topic/spack/SDR04CNRoyQ and https://groups.google.com/forum/#!topic/spack/8ep-wfq9AVw

testing

spack install hdf5%gcc+mpi^intel-mpi
spack install hdf5%intel+mpi^intel-mpi

on CentOS 7 cluster with (setup with spack compiler find after module load intelmpi)

compilers:
- compiler:
    environment: {}
    extra_rpaths: []
    flags: {}
    modules: []
    operating_system: centos7
    paths:
      cc: /usr/bin/gcc
      cxx: /usr/bin/g++
      f77: /usr/bin/gfortran
      fc: /usr/bin/gfortran
    spec: [email protected]
- compiler:
    environment: {}
    extra_rpaths: []
    flags: {}
    modules: []
    operating_system: centos7
    paths:
      cc: /apps/intel/ComposerXE2016/compilers_and_libraries_2016.3.210/linux/bin/intel64/icc
      cxx: /apps/intel/ComposerXE2016/compilers_and_libraries_2016.3.210/linux/bin/intel64/icpc
      f77: /apps/intel/ComposerXE2016/compilers_and_libraries_2016.3.210/linux/bin/intel64/ifort
      fc: /apps/intel/ComposerXE2016/compilers_and_libraries_2016.3.210/linux/bin/intel64/ifort
    spec: [email protected]
    target: x86_64

and

  intel-mpi:
    version: ['5.1.3']
    paths:
      [email protected]%[email protected]: /apps/intel/mpi/5.1.3.210/
      [email protected]%[email protected]: /apps/intel/mpi/5.1.3.210/
    buildable: False

davydden · 2017-04-19T12:28:03Z

can't test the compilation with %intel due to

Compiler error reporting is too harsh for ./configure (perhaps remove -Werror).
** ./configure aborting.

in zlib. If anyone has any ideas -- let me know...

UPDATE: it looks like i need some extra steps to set up license, here's configure.log:

Error: A license for Comp-CL is not available (-76,61026,2).

License file(s) used were (in this order):
    1.  Trusted Storage
**  2.  /apps/intel/ComposerXE2016/compilers_and_libraries_2016.3.210/linux/bin/intel64/../../Licenses
**  3.  /home/hpc/iwtm/iwtm108/Licenses
**  4.  /opt/intel/licenses
**  5.  /Users/Shared/Library/Application Support/Intel/Licenses
**  6.  /apps/intel/ComposerXE2016/compilers_and_libraries_2016.3.210/linux/bin/intel64/*.lic

Please refer http://software.intel.com/sites/support/ for more information..

This worked by loading module load intel64 before doing anything...

davydden · 2017-04-21T14:10:27Z

~~as for the flake8 issues, it appears that i can't remove those import as they are needed for the parent class.~~ nevermind, will update soon...

adamjstewart · 2017-04-21T14:32:43Z

var/spack/repos/builtin/packages/intel-mpi/package.py

+
+    def install(self, spec, prefix):
+        # FIXME:
+        raise RuntimeError('Install method is not implemented yet')


Can you implement this? It shouldn't be that different from the other Intel packages.

i added that, but i can't test it as I don't have a licence.

adamjstewart · 2017-04-21T15:19:10Z

var/spack/repos/builtin/packages/intel-mpi/package.py

+        self.intel_prefix = prefix
+        IntelInstaller.install(self, spec, prefix)
+
+


Too many blank lines

adamjstewart · 2017-04-21T15:20:59Z

var/spack/repos/builtin/packages/intel-mpi/package.py

+        # Check for presence of bin64 or bin directory
+        if os.path.isdir(self.prefix.bin):
+            bindir = self.prefix.bin
+        elif os.path.isdir(join_path(self.prefix, 'bin64')):


You might as well add prefix.bin64 to https://github.com/LLNL/spack/blob/develop/lib/spack/spack/util/prefix.py#L63

adamjstewart · 2017-04-21T15:21:26Z

var/spack/repos/builtin/packages/intel-mpi/package.py

+        elif os.path.isdir(join_path(self.prefix, 'bin64')):
+            bindir = join_path(self.prefix, 'bin64')
+        else:
+            raise "No suitable bindir found"


Don't you need an error class?

you are probably right, i blindly copy-pasted this from #2980

lee218llnl

looks good to me

lee218llnl · 2017-04-21T20:56:52Z

@davydden, looks like you have some version lines that are too long in the intel-mpi/package.py file.

adamjstewart · 2017-04-21T21:06:20Z

It's actually the hash causing the version line to be too long, not the URL. We only exempt version(...) lines, not version(..., lines. We could change that.

davydden · 2017-04-22T06:53:17Z

i updated the PR, current flake8 issues are not related

alalazo · 2017-04-22T09:51:42Z

@davydden I restarted the flake8 test on Travis and it succeeded.

…pack#3905) * intel-mpi: add new package * fix hashes * fix typo * flake8 * add install * blank line * error * add bin64 * fix MPI wrappers in intel-parallel-studio * add missing I_MPI_FC * use shorter hashes

…3905) * intel-mpi: add new package * fix hashes * fix typo * flake8 * add install * blank line * error * add bin64 * fix MPI wrappers in intel-parallel-studio * add missing I_MPI_FC * use shorter hashes

the main reason Intel-MPI was added in spack#3905 was to support a stand-alone installation, i.e. not a part of parallel studio or alike. The intended behaviour got broken during refactoring in spack#4300 This commit fixes the issue by supporting different directories.

davydden added 2 commits April 19, 2017 13:56

intel-mpi: add new package

952bc8d

fix hashes

a2a9d07

davydden added new-package WIP labels Apr 19, 2017

fix typo

0cfa06f

davydden requested a review from lee218llnl April 21, 2017 14:08

davydden removed the WIP label Apr 21, 2017

flake8

0a8ce06

adamjstewart requested changes Apr 21, 2017

View reviewed changes

add install

1b1ed20

adamjstewart reviewed Apr 21, 2017

View reviewed changes

blank line

5e9797d

adamjstewart reviewed Apr 21, 2017

View reviewed changes

davydden added 3 commits April 21, 2017 17:23

error

5b97116

add bin64

497836c

fix MPI wrappers in intel-parallel-studio

612e266

davydden force-pushed the intel-mpi branch from 170d11b to 612e266 Compare April 21, 2017 15:42

add missing I_MPI_FC

d51ee22

davydden mentioned this pull request Apr 21, 2017

Add compilers paths for dependents of intel-parallel-studio #2980

Closed

adamjstewart approved these changes Apr 21, 2017

View reviewed changes

davydden changed the title ~~add Intel mpi~~ add Intel mpi package and add MPI wrappers to Intel parallel studio Apr 21, 2017

lee218llnl approved these changes Apr 21, 2017

View reviewed changes

use shorter hashes

95ee1f4

adamjstewart merged commit 94a0cca into spack:develop Apr 22, 2017

davydden deleted the intel-mpi branch May 28, 2017 20:31

adamjstewart mentioned this pull request Jun 23, 2017

Allow arbitrary Prefix attributes #4591

Merged

davydden mentioned this pull request Jun 27, 2017

Requested changes related to mumps compilation #4614

Merged

davydden mentioned this pull request May 30, 2018

fix intel-mpi package and extend intel-mkl #8321

Closed

		self.intel_prefix = prefix
		IntelInstaller.install(self, spec, prefix)

Conversation

davydden commented Apr 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davydden commented Apr 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davydden commented Apr 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adamjstewart Apr 21, 2017

Choose a reason for hiding this comment

Uh oh!

davydden Apr 21, 2017

Choose a reason for hiding this comment

Uh oh!

adamjstewart Apr 21, 2017

Choose a reason for hiding this comment

Uh oh!

adamjstewart Apr 21, 2017

Choose a reason for hiding this comment

Uh oh!

adamjstewart Apr 21, 2017

Choose a reason for hiding this comment

Uh oh!

davydden Apr 21, 2017

Choose a reason for hiding this comment

Uh oh!

lee218llnl left a comment

Choose a reason for hiding this comment

Uh oh!

lee218llnl commented Apr 21, 2017

Uh oh!

adamjstewart commented Apr 21, 2017

Uh oh!

davydden commented Apr 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alalazo commented Apr 22, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

davydden commented Apr 19, 2017 •

edited

Loading

davydden commented Apr 19, 2017 •

edited

Loading

davydden commented Apr 21, 2017 •

edited

Loading

davydden commented Apr 22, 2017 •

edited

Loading