librsvg: add 2.56.2 and rust upper version limit for 2.51#38766
librsvg: add 2.56.2 and rust upper version limit for 2.51#38766alecbcs merged 2 commits intospack:developfrom
Conversation
|
Hi @manuelakuhn! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers("manuelakuhn")If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame librsvgThank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
| depends_on("rust", type="build", when="@2.41:") | ||
| # rust minimal version from NEWS file and upper bound because "Unaligned | ||
| # references to packed fields are a hard error" starting from 1.69 | ||
| depends_on("[email protected]:1.68", when="@2.50:", type="build") |
There was a problem hiding this comment.
@manuelakuhn do you know if building v2.56 with rust >1.68 works?
There was a problem hiding this comment.
It seems to work, at least it [email protected] installs with --test=root for me. I have added this version as well.
alecbcs
left a comment
There was a problem hiding this comment.
Confirmed SHA. PR looks good to me! Thank you @manuelakuhn for all your hard work.
* librsvg: add rust upper version limit * librsvg: Add 2.56.2
* librsvg: add rust upper version limit * librsvg: Add 2.56.2
librsvgdid not build anymore with the error:The reason for this error was this change in
[email protected]:: "Unaligned references to packed fields are now a hard error" (see Release notes). So limiting rust to@:1.68fixed it.While I was at it, I also added the minimal version requirements for the dependencies according to the configure file.